Re: [PATCH 5/8] swiotlb: refactor swiotlb_tbl_map_single

Christoph Hellwig
2021-02-05T09:45:59Z

On Thu, Feb 04, 2021 at 10:12:31PM +0000, Robin Murphy wrote:
>> - mask = dma_get_seg_boundary(hwdev);
>> + if (boundary_mask + 1 == ~0UL)
>
> Either "mask == ~0UL" or "mask + 1 == 0", surely?

I switched forth and back a few times and ended up with the broken
variant in the middle. Fixed.