From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Keith Busch <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH] nvme-multipath: set nr_zones for zoned namespaces
Date: Mon, 8 Feb 2021 23:57:47 +0900 [thread overview]
Message-ID: <20210208145747.GA8941@localhost.localdomain> (raw)
In-Reply-To: <BL0PR04MB651449A902E7FAD397E2169EE78F9@BL0PR04MB6514.namprd04.prod.outlook.com>
> Hmmm... I see the zone model being set for ns->queue, but nothing for
> ns->head->disk->queue... Shoudln't nvme_mpath_add_disk() also set the zoned
> model for ns->head->disk->queue ?
I think zone model shows properly with the simple multi-path example:
cat /sys/block/nvme0n1/queue/zoned: host-managed
cat /sys/block/nvme0c0n1/queue/zoned: host-managed
cat /sys/block/nvme0n1/queue/nr_zones: 0
cat /sys/block/nvme0c0n1/queue/nr_zones: 2048
But, there are also little more differences between the path namespace
and head namespace:
cat /sys/block/nvme0n1/queue/nr_requests: 128
cat /sys/block/nvme0c0n1/queue/nr_requests: 1023
cat /sys/block/nvme0n1/queue/iostats: 0
cat /sys/block/nvme0c0n1/queue/iostats: 1
cat /sys/block/nvme0n1/queue/rq_affinity: 0
cat /sys/block/nvme0c0n1/queue/rq_affinity: 1
+ Question with Damien's one: Shouldn't we sync all the differences
between the two request_queues?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-08 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 19:50 [PATCH] nvme-multipath: set nr_zones for zoned namespaces Keith Busch
2021-02-07 16:16 ` Christoph Hellwig
2021-02-07 23:06 ` Damien Le Moal
2021-02-08 3:28 ` Keith Busch
2021-02-08 3:51 ` Damien Le Moal
2021-02-08 14:57 ` Minwoo Im [this message]
2021-02-08 15:05 ` hch
2021-02-08 15:14 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208145747.GA8941@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=Damien.LeMoal@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox