From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46345C433DB for ; Tue, 9 Feb 2021 07:58:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A8F864EB8 for ; Tue, 9 Feb 2021 07:58:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A8F864EB8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dcn4fJv5pQ5uw9/hHY+Ha5olXf0RA0oVILd9jJIZh1I=; b=kqbfvSmhkHWF9JGInyiDsqK+Y 1yTGXZoJWCEWxG2oIkR/3UkbOPWFL/DlhlcLDv3IRrOP64b5W9I8Edm0BCT13S5E6+9IXj0mIkw11 zhk/hljW1f3DCM68XX+nwVXakGsEBl6XMxn2LfHLZ3rORud1hqUb0CNaDa/BdjwrGL1Pwf80UM5pA A7/+P9vO6yEwPrh6yDqQlfBu5PEAq9SWYjhr2lSsYo9ZqXsRtsYLu+C6p18GUvL/9pukgth5olP2B kB/YKw+sXdsJ6OpIjizhPc1rcOA1UK4jnItI34JpKz84QPJoAeTVv6KRzGngrIuDUUDoQOP4/awHC V/g1V73BA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9NuJ-0006q1-4i; Tue, 09 Feb 2021 07:57:59 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9NuH-0006pZ-7h for linux-nvme@lists.infradead.org; Tue, 09 Feb 2021 07:57:57 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 49A8067373; Tue, 9 Feb 2021 08:57:55 +0100 (CET) Date: Tue, 9 Feb 2021 08:57:55 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Subject: Re: [PATCH V2 01/11] nvmet: zeroout id-ns buffer for invalid nsid Message-ID: <20210209075755.GA31428@lst.de> References: <20210209040843.45572-1-chaitanya.kulkarni@wdc.com> <20210209040843.45572-2-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210209040843.45572-2-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_025757_423578_C8B4FB1F X-CRM114-Status: UNSURE ( 7.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org NAK. Please don't add dead code for a slow path, and please fix the actual bug in that we need to return 0 here and not an error. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme