Re: [PATCH V3 00/11] nvmet: fixes and some cleanups

Chaitanya Kulkarni
2021-02-10T08:52:30Z

On 2/10/21 00:12, Christoph Hellwig wrote:
> I've applied this to nvme-5.12 with one exception and a few tweaks.
> More in individual replies.
>
I've pulled the changes from nvme-5.12 and ran blocktests. It seems to
work fine.

# gitlog -12
26bb85e126d0 (HEAD -> nvme-5.12) Merge branch 'nvme-5.12' of
git://git.infradead.org/nvme into nvme-5.12
523bb6d79f0e (origin/nvme-5.12) nvme-hwmon: rework to avoid devm allocation
4da2cba48943 nvmet: remove else at the end of the function
7684ff0eac09 nvmet: add nvmet_req_subsys() helper
d93178da21dd nvmet: use min of device_path and disk len
ec3dc8c50add nvmet: use invalid cmd opcode helper
ff887268ac4e nvmet: use invalid cmd opcode helper
022b300c9227 nvmet: add helper to report invalid opcode
1be5d3ef5976 nvmet: remove extra variable in id-ns handler
214bffc29d79 nvmet: make nvmet_find_namespace() req based
617e7b18cc7e nvmet: return uniform error for invalid ns
275f63fa4ddb nvmet: set status to 0 in case for invalid nsid
#

# ./check tests/nvme
nvme/002 (create many subsystems and test discovery) [passed]
runtime 19.845s ... 28.439s
nvme/003 (test if we're sending keep-alives to a discovery controller)
[passed]
runtime ... 10.131s
nvme/004 (test nvme and nvmet UUID NS descriptors) [passed]
runtime 1.595s ... 1.704s
nvme/005 (reset local loopback target) [not run]
nvme_core module does not have parameter multipath
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
runtime 0.078s ... 0.112s
nvme/007 (create an NVMeOF target with a file-backed ns) [passed]
runtime 0.073s ... 0.073s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
runtime 1.619s ... 1.707s
nvme/009 (create an NVMeOF host with a file-backed ns) [passed]
runtime ... 1.663s
nvme/010 (run data verification fio job on NVMeOF block device-backed
ns) [passed]
runtime 24.800s ... 26.836s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
runtime 262.535s ... 284.324s
nvme/012 (run mkfs and data verification fio job on NVMeOF block
device-backed ns) [passed]
runtime 46.843s ... 45.088s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed
ns) [passed]
runtime 280.317s ... 324.476s
nvme/014 (flush a NVMeOF block device-backed ns) [passed]
runtime 21.985s ... 21.937s
nvme/015 (unit test for NVMe flush for file backed ns) [passed]
runtime 22.981s ... 22.106s
nvme/016 (create/delete many NVMeOF block device-backed ns and test
discovery) [passed]
runtime 15.777s ... 16.286s
nvme/017 (create/delete many file-ns and test discovery) [passed]
runtime 15.995s ... 16.244s
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
runtime 1.650s ... 1.664s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
runtime 1.677s ... 1.726s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
runtime 1.660s ... 1.668s
nvme/021 (test NVMe list command on NVMeOF file-backed ns) [passed]
runtime 1.652s ... 1.669s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns) [passed]
runtime 2.087s ... 2.098s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
runtime 1.697s ... 1.735s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
runtime 1.794s ... 1.682s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
runtime 1.658s ... 1.655s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
runtime 1.651s ... 1.694s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
runtime 1.654s ... 1.763s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
runtime 1.659s ... 1.654s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
runtime 2.007s ... 2.051s
nvme/030 (ensure the discovery generation counter is updated
appropriately) [passed]
runtime 0.321s ... 0.316s
nvme/031 (test deletion of NVMeOF controllers immediately after setup)
[passed]
runtime 5.528s ... 5.587s
nvme/038 (test deletion of NVMeOF subsystem without enabling) [passed]
runtime 0.046s ... 0.044s