From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68359C433E0 for ; Wed, 10 Feb 2021 10:10:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDC0864E32 for ; Wed, 10 Feb 2021 10:10:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDC0864E32 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jxIgzjjfx07dm9+D5q4sepewePaz6ey5rYSMgVtMDpo=; b=zoj9nnq34kpiLfcUSO9Y8UNfn X5Jgfni3jNpie5xeZ+2mNAxmoY6JVkxZq6Ul6TsRnk5iSw5XabW4jCjv+kIGXUJ0jV7VsHQsUpTsd sqLBAcTsEBj9PpeqtdH6A1/EdmA8naJzvw4pgnvfqaVV0fqjHzCjSJWbpuJQYNjl0FMFGij2nj5VM k8zideHNoxFhpK3fDlgH1e21IFkV7lqeqlA/3aJj3Q1nksEdJjbix4gT4vHXPVYyIQlzWevjxFlvh DNON5koMMOZG7aqoal8kPTfUaxbf9KTmDorwsC53LP9zn8P8RFmD0Xs5bie4N6SMbQp+a/7wTzeEl tgjHlBA/w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9mSL-0002hV-Ac; Wed, 10 Feb 2021 10:10:45 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9mSJ-0002go-2e for linux-nvme@lists.infradead.org; Wed, 10 Feb 2021 10:10:44 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id D2A246736F; Wed, 10 Feb 2021 11:10:38 +0100 (CET) Date: Wed, 10 Feb 2021 11:10:37 +0100 From: Christoph Hellwig To: Sagi Grimberg Subject: Re: [PATCH 1/2] nvmet: don't check iosqes,iocqes for discovery controllers Message-ID: <20210210101037.GA26576@lst.de> References: <20210209101235.1539917-1-sagi@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210209101235.1539917-1-sagi@grimberg.me> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_051043_257492_7D42818D X-CRM114-Status: GOOD ( 10.05 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Christoph Hellwig , linux-nvme@lists.infradead.org, Martin.Belanger@dell.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Feb 09, 2021 at 02:12:34AM -0800, Sagi Grimberg wrote: > + if (!ctrl->subsys->type == NVME_NQN_DISC && I think the normal way to write this would be a !=. > + (nvmet_cc_iosqes(ctrl->cc) != NVME_NVM_IOSQES || > + nvmet_cc_iocqes(ctrl->cc) != NVME_NVM_IOCQES)) { By the spec we'd need to check these are 0, but of course we'd break the existing Linux host. Maybe throw in a comment? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme