From: Christoph Hellwig <hch@lst.de>
To: Gopal Tiwari <gtiwari@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
kbusch@kernel.org, hch@lst.de, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-pci: prevent SK Hynix PE8000 from using Write Zeroes command
Date: Wed, 10 Feb 2021 14:15:57 +0100 [thread overview]
Message-ID: <20210210131557.GB29904@lst.de> (raw)
In-Reply-To: <211078952.30654328.1612955843198.JavaMail.zimbra@redhat.com>
MDTS vs Write Zeroes is a common misconception. We had that discussion
in the NVMe working group, and while the text should pretty clear that
MDTS only applies to data transfers many implementators did not understand
that, which is why we added the clarification you quoted.
Also the next NVMe spec will allow devices to advertise an explicit
Write Zeroes limit, take a look at TP4040 from the "NVM Express 1.4 Ratified
TPs" at https://nvmexpress.org/developers/nvme-specification/.
So I think limiting to MDTS unless the new WZSL is set might be a fail
safe option, even if it is more pessimistic than what the spec says.
I'd also love to retest most Write Zeroes quirks with that in place.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-10 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 4:59 [PATCH] nvme-pci: prevent SK Hynix PE8000 from using Write Zeroes command Gopal Tiwari
2021-02-09 5:38 ` Chaitanya Kulkarni
2021-02-09 5:59 ` Gopal Tiwari
2021-02-10 10:12 ` Christoph Hellwig
2021-02-10 11:17 ` Gopal Tiwari
2021-02-10 13:15 ` Christoph Hellwig [this message]
2021-02-10 22:11 ` Chaitanya Kulkarni
2021-02-11 7:07 ` Christoph Hellwig
2021-02-11 18:11 ` Chaitanya Kulkarni
2021-02-24 9:13 ` Christoph Hellwig
2021-02-25 2:09 ` Chaitanya Kulkarni
2021-02-25 7:56 ` Gopal Tiwari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210131557.GB29904@lst.de \
--to=hch@lst.de \
--cc=gtiwari@redhat.com \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox