public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: sagi@grimberg.me, chaitanya.kulkarni@wdc.com,
	linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
	kbusch@kernel.org, oren@nvidia.com
Subject: Re: [PATCH 1/1] nvmet: allow setting model_number once
Date: Wed, 24 Feb 2021 11:00:47 +0100	[thread overview]
Message-ID: <20210224100047.GA9017@lst.de> (raw)
In-Reply-To: <119dbae3-9dc8-a5d8-0f35-20d619931db6@nvidia.com>

On Wed, Feb 24, 2021 at 11:59:22AM +0200, Max Gurtovoy wrote:
> you don't need the id argument here.
>
> Otherwise looks good and it can be squashed to my patch.

Can you resend it with the updates?

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-02-24 10:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 18:11 [PATCH 1/1] nvmet: allow setting model_number once Max Gurtovoy
2021-02-18  3:17 ` Chaitanya Kulkarni
2021-02-18  9:51   ` Max Gurtovoy
2021-02-24  9:43 ` Christoph Hellwig
2021-02-24  9:59   ` Max Gurtovoy
2021-02-24 10:00     ` Christoph Hellwig [this message]
2021-02-24 10:02       ` Max Gurtovoy
2021-02-24 10:04         ` Christoph Hellwig
2021-02-24 12:57           ` Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224100047.GA9017@lst.de \
    --to=hch@lst.de \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mgurtovoy@nvidia.com \
    --cc=oren@nvidia.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox