From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B52EFC433E0 for ; Wed, 24 Feb 2021 16:22:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4135B64EDD for ; Wed, 24 Feb 2021 16:22:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4135B64EDD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dyD0Ju3XkGiy07yXHPgFbQERC2qk16+nDE1E11S9GRM=; b=Sv2d1KpAFRoJukjYfEtpq2jY9 fv3bI5BublV/rbSqJ+PVUPQvhIrPsx9t92DveQDuq9LBYuPrSrHPaILljpEJx3OJORaDa+BOYf497 MLJuHat/XetYmm+j0CNsZYn5yNi/MnU5hn422/lBNFExYEABWFh9elHhojf3amC1v06g/22dJopO4 Dyii6MMqHIJ01BHCzaRiPp0lX7wTQ868MLKsOL4GkM8ZmkFrGr/NELBT2glttvFSmviQt9WDvknA4 JQ1ofCvsHrqY8J6yjhNtEMn8oNm8CHSDjNahmLtctp1iWrWN1dok7BCfakJKGsl3i7dG/sBlN9W6e 8VIn5HUHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEwva-0002lY-Hp; Wed, 24 Feb 2021 16:22:18 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEwvX-0002lG-BM for linux-nvme@lists.infradead.org; Wed, 24 Feb 2021 16:22:16 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4C46267357; Wed, 24 Feb 2021 17:22:10 +0100 (CET) Date: Wed, 24 Feb 2021 17:22:10 +0100 From: Christoph Hellwig To: Hannes Reinecke Subject: Re: [PATCH 1/2] nvme: fixup kato deadlock Message-ID: <20210224162210.GA9780@lst.de> References: <20210223120728.104699-1-hare@suse.de> <20210223120728.104699-2-hare@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210223120728.104699-2-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210224_112215_519897_9CB483FD X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvme@lists.infradead.org, Daniel Wagner , Christoph Hellwig , Keith Busch , Sagi Grimberg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Well, kato really should be doing a nowait request allocation instead of beeing stuck. That being said we currently have two reserved requests, with one set aside for connect. This does back to the initial commit, but I can't see how a keep alive could still be around when we reconnect, so I think one reserved command should be fine as well. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme