From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: kbusch@kernel.org, hch@lst.de, linux-nvme@lists.infradead.org,
sagi@grimberg.me
Subject: Re: [PATCH 01/14] nvme-core: remove duplicate kfree in init identify
Date: Wed, 24 Feb 2021 17:35:05 +0100 [thread overview]
Message-ID: <20210224163505.GD10673@lst.de> (raw)
In-Reply-To: <20210217001032.25741-2-chaitanya.kulkarni@wdc.com>
On Tue, Feb 16, 2021 at 04:10:19PM -0800, Chaitanya Kulkarni wrote:
> In nvme_init_identify() once we initialize nvme_mpath_init() we free
> the id with kfree(). This is needed since we just return from all the
> following calls to nvme_mpath_init(), that also makes kfree() call
> duplicate.
>
> Instead of returning after nvme_mpath_init() jump to the lable
> out_free and remove the duplicate call to the kfree() since out_free
> label already has one..
Hmm. I'd rather split nvme_init_identify. Rename the publically
called function to something like nvme_init_ctrl_finish, and
the split out a nvme_init_identify for just the section that deals
with the id_ns data.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-24 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 0:10 [PATCH 00/14] nvme: few cleanups and small improvements Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 01/14] nvme-core: remove duplicate kfree in init identify Chaitanya Kulkarni
2021-02-24 16:35 ` Christoph Hellwig [this message]
2021-02-24 22:35 ` Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 02/14] nvme-core: don't use switch for only one case use Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 03/14] nvme-core: use right type for ARRAY_SIZE check Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 04/14] nvme-core: fix the type for shutdown_timeout Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 05/14] nvme-core: add helper to init ctrl transport attr Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 06/14] nvme-core: add helper to init shutdown timeout Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 07/14] nvme-core: add helper to init ctrl subsys quirk Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 08/14] nvme-core: move util quirk at the top of the file Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 09/14] nvme-core: mark nvme_setup_passsthru() inline Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 10/14] nvme-core: remove one liner wrappers for streams Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 11/14] nvme-core: use likely in nvme_init_request() Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 12/14] nvme-core: don't check nvme_req flags for new req Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 13/14] nvme-fc: fix the function documentation comment Chaitanya Kulkarni
2021-02-17 0:10 ` [PATCH 14/14] nvmet-fc: update function documentation Chaitanya Kulkarni
2021-02-24 15:42 ` [PATCH 00/14] nvme: few cleanups and small improvements Keith Busch
2021-02-24 21:52 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224163505.GD10673@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox