* [PATCH] nvme-multipath: use nvme_ctrl_use_ana helper to check ANA
@ 2021-02-25 10:57 Minwoo Im
2021-03-05 22:35 ` Sagi Grimberg
2021-03-09 10:07 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Minwoo Im @ 2021-02-25 10:57 UTC (permalink / raw)
To: linux-nvme
Cc: Keith Busch, Jens Axboe, Minwoo Im, Christoph Hellwig,
Sagi Grimberg
Call nvme_ctrl_use_ana helper to check whether the given controller uses
ANA or not.
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
drivers/nvme/host/multipath.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index c658b73a41b7..bbb582b12226 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -82,7 +82,7 @@ void nvme_failover_req(struct request *req)
* ready to serve this namespace. Kick of a re-read of the ANA
* information page, and just try any other available path for now.
*/
- if (nvme_is_ana_error(status) && ns->ctrl->ana_log_buf) {
+ if (nvme_is_ana_error(status) && nvme_ctrl_use_ana(ns->ctrl)) {
set_bit(NVME_NS_ANA_PENDING, &ns->flags);
queue_work(nvme_wq, &ns->ctrl->ana_work);
}
--
2.25.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-multipath: use nvme_ctrl_use_ana helper to check ANA
2021-02-25 10:57 [PATCH] nvme-multipath: use nvme_ctrl_use_ana helper to check ANA Minwoo Im
@ 2021-03-05 22:35 ` Sagi Grimberg
2021-03-09 10:07 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2021-03-05 22:35 UTC (permalink / raw)
To: Minwoo Im, linux-nvme; +Cc: Keith Busch, Jens Axboe, Christoph Hellwig
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-multipath: use nvme_ctrl_use_ana helper to check ANA
2021-02-25 10:57 [PATCH] nvme-multipath: use nvme_ctrl_use_ana helper to check ANA Minwoo Im
2021-03-05 22:35 ` Sagi Grimberg
@ 2021-03-09 10:07 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-03-09 10:07 UTC (permalink / raw)
To: Minwoo Im
Cc: linux-nvme, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg
Thanks,
applied to nvme-5.13.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-09 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-25 10:57 [PATCH] nvme-multipath: use nvme_ctrl_use_ana helper to check ANA Minwoo Im
2021-03-05 22:35 ` Sagi Grimberg
2021-03-09 10:07 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).