From: Keith Busch <kbusch@kernel.org>
To: Klaus Jensen <its@irrelevant.dk>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de
Subject: Re: [PATCH] nvme: implement non-mdts command limits
Date: Thu, 11 Mar 2021 12:18:22 -0700 [thread overview]
Message-ID: <20210311191822.GB36893@C02WT3WMHTD6> (raw)
In-Reply-To: <YEo+UOu6paVwzdXY@apples.localdomain>
On Thu, Mar 11, 2021 at 04:59:12PM +0100, Klaus Jensen wrote:
> On Mar 12 00:49, Keith Busch wrote:
> > On Thu, Mar 11, 2021 at 06:51:26AM +0100, Klaus Jensen wrote:
> > > On Mar 10 11:57, Keith Busch wrote:
> > > > + if (id->dmrsl)
> > > > + ctrl->max_discard_sectors = le32_to_cpu(id->dmrsl);
> > >
> > > Since DMRSL is in terms of LBAs, should this use nvme_lba_to_sect?
> >
> > We need a namespace for that, but we only have a controller for this
> > Identify.
>
> Ah yes.
>
> I remember now that I also complained loudly about this mistake in the
> spec when we implemented it in QEMU.
Worse case scenario is that our 512b assumption will get a slightly smaller
maximum DSM, but it should at least always be safe and successful. I think it
would be nice if the spec clears this up too.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2021-03-11 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 19:57 [PATCH] nvme: implement non-mdts command limits Keith Busch
2021-03-10 20:12 ` Keith Busch
2021-03-11 5:51 ` Klaus Jensen
2021-03-11 15:49 ` Keith Busch
2021-03-11 15:59 ` Klaus Jensen
2021-03-11 19:18 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311191822.GB36893@C02WT3WMHTD6 \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=its@irrelevant.dk \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox