From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39161C433B4 for ; Fri, 2 Apr 2021 17:17:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD1566113E for ; Fri, 2 Apr 2021 17:17:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD1566113E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R0Qac6NDEIdzGLo758qdL8ztkFHLN9lkORQBLkNqRnQ=; b=aaZTl7lqPRl+d5a/DlVQ+XnLl rjHudCJPbGc8l0eO5WMis+SLCR8Srs6eIZ+CIRi+r3ipGMifMk2rS+PS+IXf0KkWTq49J4B3+Zzv8 /YyMZPNIU+J/IabrLTDtilPB8t5qRKN4wBKP3NsiqOcgZG8fo64oxckSraGspaMok+EqHr+KiRdKI u+s8FqK9CPZL+EFlZ+FqA0nGgciH7YUGNfBPyUQ87bUrs1hxh5OlrUg+toqLzB+t1TYrQB4nLFuBO WclTXgrQRlmsy341JP13YJqipAONBf3Kd/IlEjZ3ZUGSYcRW3gdTExZaKiEf/EQxS2bbSfnNuj9Bc JVPI6jG8w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSNPh-00DU9P-QU; Fri, 02 Apr 2021 17:16:53 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSNPe-00DU8o-H5 for linux-nvme@lists.infradead.org; Fri, 02 Apr 2021 17:16:52 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 7601268BEB; Fri, 2 Apr 2021 19:16:48 +0200 (CEST) Date: Fri, 2 Apr 2021 19:16:48 +0200 From: Christoph Hellwig To: Niklas Cassel Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , "minwoo.im.dev@gmail.com" , "javier@javigon.com" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH] nvme: allow NVME_IOCTL_IO_CMD on controller char dev even when multiple ns Message-ID: <20210402171648.GA22651@lst.de> References: <20210326205943.431185-1-Niklas.Cassel@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210326205943.431185-1-Niklas.Cassel@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_181650_636037_FB0E2274 X-CRM114-Status: GOOD ( 10.36 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Well, there is at least one good reason for not allowing this retroactively: Old users of the ioctl could have complete garbage in the field, and might send the command to a random namespace now instead of the first one. So unles we have a very good reason I think we should keep NVME_IOCTL_IO_CMD on the controller char dev deprecated and maybe eventually remove it. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme