From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 781B9C433B4 for ; Wed, 7 Apr 2021 17:14:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA3F36121E for ; Wed, 7 Apr 2021 17:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA3F36121E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o6w7tWVBMKkOW0I7jZvf1VY4do6SVYHt+iREtl3bmRk=; b=dUr2Bhsb6IFABvXPicRfJZAlR agI+i1VqTgoeprVKkYXseAkRj9G6/Vwn2Ayq10/bjNqOt153kAREp1z/AXmIo50WaR8WRmD+SZIvO ++7Vmpx6flkzBvln6HKoPcBsrZa6qaOFj2O4bPY4+I5I2vzEZcrs5PV5TGDh8SujFKyMm/gs5c0k+ dVc98S4ylz9kmSM/wh9LChYangjM8PMuV+mSoHlnlZotnJujfIFfOjWETuGq6w3SNanzVE5LbxHhJ qKtYIbVhyAFTBJ7gqz3+YOf1FhhGV79c488ycxDhQRY+4lXVbvNoRVeBt3rjoYTm3ZRHg386kFghD n+/Z1FuDw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUBkj-005bnD-9L; Wed, 07 Apr 2021 17:14:05 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUBkg-005bmK-Es for linux-nvme@lists.infradead.org; Wed, 07 Apr 2021 17:14:04 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 39B1168B05; Wed, 7 Apr 2021 19:14:00 +0200 (CEST) Date: Wed, 7 Apr 2021 19:14:00 +0200 From: Christoph Hellwig To: Minwoo Im Cc: Christoph Hellwig , linux-nvme@lists.infradead.org, Keith Busch , Jens Axboe , Sagi Grimberg , Kanchan Joshi , Javier =?iso-8859-1?Q?Gonz=E1lez?= Subject: Re: [PATCH V2 1/1] nvme: introduce generic per-namespace chardev Message-ID: <20210407171400.GA32592@lst.de> References: <20210406064841.103393-1-minwoo.im.dev@gmail.com> <20210406064841.103393-2-minwoo.im.dev@gmail.com> <20210407131527.GA15142@lst.de> <20210407141128.GB2805@localhost> <20210407142152.GA20466@lst.de> <20210407153536.GA8667@localhost> <20210407154730.GC8667@localhost> <20210407164818.GA31878@lst.de> <20210407170905.GB9994@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210407170905.GB9994@localhost> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_181402_614557_7E631188 X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Apr 08, 2021 at 02:09:05AM +0900, Minwoo Im wrote: > On 21-04-07 18:48:18, Christoph Hellwig wrote: > > I've force pushed the branch with the updates, let me know if this > > looks good to you. > > One more thing I'd like to discuss is that the current branch does not > create generic cdev in case that nvme_update_ns_info fails. And this is > the one of the use cases of the generic devices, so do you think it > should approach as an another patch ? Or, should we make it supported > in the current patch ? It should create the ng devices when nvme_update_ns_info fais with -ENODEV, which should handle all the ZNS cases is was created. Or did I mess that up? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme