From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1D6C433ED for ; Thu, 8 Apr 2021 07:15:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C665961041 for ; Thu, 8 Apr 2021 07:15:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C665961041 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZhctH5hsHcfru8ePGsaBLRovfa74VyvTjLTFlPSPoxU=; b=XJLDJVGHQiIXy1CVlMXrgCH66 Doumxu8CFFmIacLvmuMh6sQkLaLlJmut7o1P4JMDSEMLu75mqUZcu52I2afH4sIhapeFzrKfx+C/6 OxmbezUeAmOUHkzY6EwaHL/nNnH8uHfan6PsCjFtSuOAbQfTVT98jku88naJia776SuROkCxYUtQ+ nJOB2AJ606ycILIDpb+NLC2vJHXmjdiV/H5eBzTQFkMouEshBOBWy3MzxV/N/AypLkvV9bxH7jql0 LljCTKksZ8BhVfWrlNvTsSE01ueOj8wDe9Sp3vcVeYu+9juRehGtn0njSJzRLHaorUtD6REpMlnGv 5FQt4fRvA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUOsv-007AOh-Av; Thu, 08 Apr 2021 07:15:26 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUOsq-007ANl-HE for linux-nvme@lists.infradead.org; Thu, 08 Apr 2021 07:15:23 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 31DE768B05; Thu, 8 Apr 2021 09:15:18 +0200 (CEST) Date: Thu, 8 Apr 2021 09:15:17 +0200 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, hch@lst.de, damien.lemoal@wdc.com Subject: Re: [PATCH V13 1/4] nvmet: add NVM Command Set Identifier support Message-ID: <20210408071517.GA24502@lst.de> References: <20210408001427.20501-1-chaitanya.kulkarni@wdc.com> <20210408001427.20501-2-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210408001427.20501-2-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_081521_810500_F9EFEC4D X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org s/NVM // in the subject. > -static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req) > +static void nvmet_set_csi_nvm_effects(struct nvme_effects_log *log) Maybe call this nvmet_get_cmd_effects_nvm? > +static u16 nvmet_execute_identify_desclist_csi(struct nvmet_req *req, off_t *o) > +{ > + switch (req->ns->csi) { > + case NVME_CSI_NVM: > + return nvmet_copy_ns_identifier(req, NVME_NIDT_CSI, > + NVME_NIDT_CSI_LEN, > + &req->ns->csi, o); > + } > + > + return NVME_SC_INVALID_IO_CMD_SET; No need for a switch here, this can just copy the csi value in the nvmet_ns structure (which also means that we probably don't need this helper at all). > +static inline bool nvmet_cc_css_check(u8 cc_css) I'd call this nvmet_css_supported. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme