From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0804C433B4 for ; Fri, 9 Apr 2021 09:54:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CED36115B for ; Fri, 9 Apr 2021 09:54:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CED36115B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xwm5QBAcLYWcDK7iqa8jwe36GsoIDbgMBj4JZEDa/gY=; b=eFF/Cml/hV0dtxm59gl/ppo7m 6dUrVE1Y3bx65mKY6tKl3t2AOaIv0XNQvgPIPYKMXrJqkvdEZ1of0zRVWjeHTy83nHc3EshuGcZv2 GSRX7tF86nbiAPsF6up+nu50OX3i2iiCeeY7xVCldK8Qx3zmnKJaXTTgfF3v/tHgM6iX9bDV892gx 7Wfl4V+mC0Ed/uSuAevsnbLq/oPWwVVANJvQKrVn9a9q3KQm/O6dlHUQc3lloAAHEQYwk/yurTuMO vy643fRmCWdSS7RNXzmPGqrCiq7UeHxgfBshMwabilDaYbiuy09TxUC5o8mwuTTq3kCDFjAYpWQzV Oszg8U+lg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUnpi-000KOk-2J; Fri, 09 Apr 2021 09:53:46 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUnpa-000KMq-W6 for linux-nvme@lists.infradead.org; Fri, 09 Apr 2021 09:53:41 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id CB37568B02; Fri, 9 Apr 2021 11:53:37 +0200 (CEST) Date: Fri, 9 Apr 2021 11:53:37 +0200 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: Christoph Hellwig , "linux-nvme@lists.infradead.org" , Damien Le Moal Subject: Re: [PATCH V13 2/4] nvmet: add ZBD over ZNS backend support Message-ID: <20210409095337.GA16010@lst.de> References: <20210408001427.20501-1-chaitanya.kulkarni@wdc.com> <20210408001427.20501-3-chaitanya.kulkarni@wdc.com> <20210408072337.GB24502@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_105339_278357_3748311B X-CRM114-Status: GOOD ( 14.34 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Apr 09, 2021 at 07:09:12AM +0000, Chaitanya Kulkarni wrote: > diff --git a/drivers/nvme/target/admin-cmd.c > b/drivers/nvme/target/admin-cmd.c > index fc5f64a38661..da6d5225f25a 100644 > --- a/drivers/nvme/target/admin-cmd.c > +++ b/drivers/nvme/target/admin-cmd.c > @@ -685,6 +685,14 @@ static void nvmet_execute_identify(struct nvmet_req > *req) > if (!nvmet_check_transfer_len(req, NVME_IDENTIFY_DATA_SIZE)) > return; > > + switch (req->cmd->identify.csi) { > + case NVME_CSI_NVM: > + case NVME_CSI_ZNS: > + break; > + default: > + goto out; > + } > + I don't think thi is the right thing to do as only a few CNS values look at the CSI, so we'd need this switch in those switch cases that need CNS values only. The rest looks good. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme