From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: generate uevent once a multipath namespace is operational again
Date: Thu, 6 May 2021 09:37:40 +0200 [thread overview]
Message-ID: <20210506073740.GB14615@lst.de> (raw)
In-Reply-To: <20210505103305.107475-1-hare@suse.de>
On Wed, May 05, 2021 at 12:33:05PM +0200, Hannes Reinecke wrote:
> In an all paths down scenario I/O will be requeued or aborted, so no
> further I/O will be ongoing on this namespace.
> This leaves upper layers like MD unable to determine if the namespace
> becomes operational again after a successful controller reset.
> This patch will send an uevent per multipathed namespace once the
> underlying controller is LIVE, allowing MD to start resync.
Do we have any documentation or other exampes for this KOBJ_CHANGED
magic? I've seen it in a few places, but it always seemed rather
cargo cult to me. If you have a more insights any chance you could
document it?
> + if (ctrl->state == NVME_CTRL_LIVE)
> + kobject_uevent(&disk_to_dev(ns->head->disk)->kobj,
> + KOBJ_CHANGE);
Also this should probably use disk_uevent to also notify partitions.
Maybe also for other existing callers.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-06 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 10:33 [PATCH] nvme: generate uevent once a multipath namespace is operational again Hannes Reinecke
2021-05-06 7:37 ` Christoph Hellwig [this message]
2021-05-06 8:48 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506073740.GB14615@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox