From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCH 1/3] nvme-tcp: don't check blk_mq_tag_to_rq when receiving pdu data
Date: Tue, 18 May 2021 08:59:09 +0200 [thread overview]
Message-ID: <20210518065909.GA8300@lst.de> (raw)
In-Reply-To: <20210517175955.602725-2-sagi@grimberg.me>
> +++ b/drivers/nvme/host/tcp.c
> @@ -699,12 +699,6 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb,
> struct request *rq;
>
> rq = blk_mq_tag_to_rq(nvme_tcp_tagset(queue), pdu->command_id);
> - if (!rq) {
> - dev_err(queue->ctrl->ctrl.device,
> - "queue %d tag %#x not found\n",
> - nvme_tcp_queue_id(queue), pdu->command_id);
> - return -ENOENT;
> - }
> req = blk_mq_rq_to_pdu(rq);
We could simplify the initialization a bit now:
struct request *rq =
blk_mq_tag_to_rq(nvme_tcp_tagset(queue), pdu->command_id);
struct nvme_tcp_request *req = blk_mq_rq_to_pdu(rq);
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-18 6:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 17:59 [PATCH 0/3] nvme: protect against possible request reference after completion Sagi Grimberg
2021-05-17 17:59 ` [PATCH 1/3] nvme-tcp: don't check blk_mq_tag_to_rq when receiving pdu data Sagi Grimberg
2021-05-18 6:59 ` Christoph Hellwig [this message]
2021-05-17 17:59 ` [PATCH 2/3] nvme-pci: limit maximum queue depth to 4095 Sagi Grimberg
2021-05-18 7:01 ` Christoph Hellwig
2021-05-17 17:59 ` [PATCH 3/3] nvme: code command_id with a genctr for use-after-free validation Sagi Grimberg
2021-05-17 19:04 ` Keith Busch
2021-05-17 20:23 ` Sagi Grimberg
2021-05-17 19:09 ` Bart Van Assche
2021-05-17 19:46 ` Keith Busch
2021-05-17 20:27 ` Sagi Grimberg
2021-05-17 20:28 ` Bart Van Assche
2021-05-17 21:50 ` Sagi Grimberg
2021-05-17 22:06 ` Bart Van Assche
2021-05-17 22:15 ` Sagi Grimberg
2021-05-17 18:47 ` [PATCH 0/3] nvme: protect against possible request reference after completion Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518065909.GA8300@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox