From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org, Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH] nvme-multipath: call del_gendisk() in nvme_mpath_check_last_path()
Date: Thu, 3 Jun 2021 09:22:44 +0200 [thread overview]
Message-ID: <20210603072244.GA4687@lst.de> (raw)
In-Reply-To: <20210531070914.102439-1-hare@suse.de>
> +void nvme_mpath_check_last_path(struct nvme_ns *ns)
> {
> + struct nvme_ns_head *head = ns->head;
> +
> if (!head->disk)
> return;
> - if (head->disk->flags & GENHD_FL_UP) {
> +
> + if (list_empty(&head->list) && head->disk->flags & GENHD_FL_UP) {
Please add the braces around the "&".
> nvme_cdev_del(&head->cdev, &head->cdev_device);
> del_gendisk(head->disk);
> }
> +}
Also it seems like we can just pass the head here, no need for ns.
> - if (head->disk && list_empty(&head->list))
> - kblockd_schedule_work(&head->requeue_work);
Did this get lost in the new version?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-06-03 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 7:09 [PATCH] nvme-multipath: call del_gendisk() in nvme_mpath_check_last_path() Hannes Reinecke
2021-06-03 7:22 ` Christoph Hellwig [this message]
2021-06-03 7:31 ` Christoph Hellwig
2021-06-07 9:46 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603072244.GA4687@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox