From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780BCC48BE5 for ; Mon, 21 Jun 2021 05:33:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 011A06109F for ; Mon, 21 Jun 2021 05:33:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 011A06109F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z1RfcSeJuoVbB5/B1N7P5Ko5gq5qT0HJQcuO1O4CgPo=; b=fr4I4rsez6Ce4z Z3ddoj2/4J0oiZbZPh2E0jrHmF/dZX3zswObt5Kej7ndm4s0kroufISCIxa1hW2uCN+IznmnaFXoW 1dLC+p2LblKkKQDXZiyMCdOUz22pxCrfyGUKpPcwK6G31THzXZg6+hgDAFOiayxqFhaHQhqD80Cen xDjr2j0dxHPrJlcecayl3RbLHCHrVaylgAZBJU0CsmBYcgZeORo+4SBI4rU5t0xzHkvyBy7IjdcES haN6wFsZ7WTFfIz85GvoWa3aIvEWYZScHXEhCFBtC2IeSPByRJH0Y3poJ+YBZTqiQKZAJRXrvEqtV W4RZf8yo9rKA83aYwt+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvCYL-002CZV-Nx; Mon, 21 Jun 2021 05:32:57 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvCYI-002CYp-Rs for linux-nvme@lists.infradead.org; Mon, 21 Jun 2021 05:32:56 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id D31DF68BEB; Mon, 21 Jun 2021 07:32:51 +0200 (CEST) Date: Mon, 21 Jun 2021 07:32:51 +0200 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me, kbusch@kernel.org Subject: Re: [PATCH] nvme: add comment to not use kobj_to_dev() Message-ID: <20210621053251.GA4360@lst.de> References: <20210621030940.22286-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210621030940.22286-1-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210620_223255_098615_7CD86AC9 X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sun, Jun 20, 2021 at 08:09:40PM -0700, Chaitanya Kulkarni wrote: > Add a comment in nvme_ns_id_attrs_are_visible() and > nvme_dev_attrs_are_visible() not to replace container_of() with > kobj_to_dev(). Since use of kobj_to_dev() makes code harder to read. > > Suggested-by: Keith Busch > Signed-off-by: Chaitanya Kulkarni Err, no. This code is completely obvious as is, and if people keep sending these stupid patches we need to start blacklisting them. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme