Re: [PATCH v4 01/20] nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP

From: Christoph Hellwig <hch@lst.de>
To: Shai Malin <malin1024@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Prabhakar Kushwaha <pkushwaha@marvell.com>,
	linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
	axboe@fb.com, Keith Busch <kbusch@kernel.org>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Shai Malin <smalin@marvell.com>,
	Ariel Elior <aelior@marvell.com>,
	Michal Kalderon <mkalderon@marvell.com>,
	okulkarni@marvell.com, prabhakar.pkin@gmail.com,
	Dean Balandin <dbalandin@marvell.com>
Subject: Re: [PATCH v4 01/20] nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP
Date: Fri, 16 Jul 2021 09:45:03 +0200	[thread overview]
Message-ID: <20210716074503.GC14800@lst.de> (raw)
In-Reply-To: <CAKKgK4wN49NX+pDff5eFbebeTWBi4aMK9CVMmq4jixgtXHRmQA@mail.gmail.com>

On Mon, Jul 05, 2021 at 06:09:58PM +0300, Shai Malin wrote:
> > > +static void __exit nvme_tcp_ofld_cleanup_module(void)
> > > +{
> > > +     nvmf_unregister_transport(&nvme_tcp_ofld_transport);
> > > +}
> >
> > Looking at the final result this doesn't do much.  Assuming we want
> > to support these kinds of whacky offloads (which I'd rather not do),
> > the proper way would be to allow registering multiple transport_ops
> > structures for a given name rather adding an indirection that duplicates
> > a whole lot of code.
> 
> In that case, would you prefer that we invoke the tcp-offload from
> within the tcp flow?
> Should it be with the same transport name (“tcp”) or with a different
> transport name (“tcp_offload”)?
> 
> Also, would you prefer that we register the offload device driver
> directly to blk_mq layer or through the tcp-offload layer?

As said, we should allow the different offload drivers register
as te offload transport and just iterate through the multiple instances
of the transport until we find a match instead of duplicating the
registration infrastructure.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme