Re: [PATCH v3 3/8] nvme: add error handling support for add_disk()

Christoph Hellwig
2021-09-06T08:09:44Z

On Mon, Sep 06, 2021 at 08:16:35AM +0200, Hannes Reinecke wrote:
> I would rather turn this around, and call 'nvme_put_ctrl()' after removing
> the namespace from the list. But it's probably more a style issue, come to
> think of it.

The order in the patch is the inverse of the order before the failure,
which generally is the right thing to do.