From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0973C433F5 for ; Mon, 13 Sep 2021 06:13:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B1C760F3A for ; Mon, 13 Sep 2021 06:13:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B1C760F3A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4xq9+qMXpjbN5i67TPuHmIDy7rD/EV/ZWUqNBtwnD9k=; b=NGLX76vIVR3ADr h390akj0+w4YvGnVWug3zG7W7DwBQADAu7+/WKvG8v59/MxbNOGkzxfIN3ivIPqYo2zSrKMUWD6Fq ANCB4Vdnsnhja+Y2suUNWPD82503uy5AGCjMsRFYBvELoPy4JMRSxRG1KpGb9qQnqARMnUhHEcTZ5 ZJVqtLTKdhmF+acjLgfVghd6yq6/DssOlkTO3kkF6+cXe7TUGL7VRkAF2rnXJmuqRFBQWgm5Yl1hU +qxvxEJmaQjlbCbwyZTNaoTZxVcWWN/PwTKQ243A76eTBLnA++23z5GpejXvpg9jq0Bkjb7imGrvY L4dM8+ewrnvY2JUXUG7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPfDJ-000PyM-8F; Mon, 13 Sep 2021 06:13:09 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPfDG-000Pww-BP for linux-nvme@lists.infradead.org; Mon, 13 Sep 2021 06:13:07 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6F1E067373; Mon, 13 Sep 2021 08:13:03 +0200 (CEST) Date: Mon, 13 Sep 2021 08:13:03 +0200 From: Christoph Hellwig To: Lihong Kou Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v2] block: nvme: fix the NULL ptr bug in bio_integrity_verify_fn Message-ID: <20210913061303.GA4324@lst.de> References: <20210911024906.1125259-1-koulihong@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210911024906.1125259-1-koulihong@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210912_231306_584265_31936A1E X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > - blk_integrity_unregister(disk); > + if (blk_get_integrity(disk)) > + blk_integrity_unregister(disk); Instead of open coding this in the callers I think we should make blk_integrity_unregister a no-op if no integrity profile was registered. Also please split this into two logically separate patches. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme