From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9024FC433F5 for ; Wed, 13 Oct 2021 09:11:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5131861077 for ; Wed, 13 Oct 2021 09:11:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5131861077 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=szaGkyEBjQfMaK7B9lSVbnpMYp1Jn+37FCr1Uhg7wmo=; b=ogNKDQJuwvtQMl iQBuWUrQP7viPZi8Wu7YmKvvOQJeNsILIDbi0Vw27jen66BZpkrOgopTwCy0zuID6za4KiiAenZoG Ugl9HWy38xt7dmrlx4IMg3dSlqKUj7KxojsYskVBQV5P77tTieyvPEM6cYxWblbvU1uTjZGY1y4Md 679RKnjFOd4Y9F/2G7cXO16BI33G0I+Rs1UnAbWc4yoK6iyndtzK1hEc7csbC4eTTXtFWwJxZqJ1t 5suLoRWn1MccHdkG7NKeRKurZv9mHe8r4/ywm64K/jwq7h2ItTCSTz1+C1R1ShD+NEhiHNziR4ACD 5qevZhReZwL4YO+RkHvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maaHx-00FiqG-Ev; Wed, 13 Oct 2021 09:11:05 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXYj-00F7Es-Do for linux-nvme@lists.infradead.org; Wed, 13 Oct 2021 06:16:14 +0000 Received: by mail-pg1-x533.google.com with SMTP id s75so1320860pgs.5 for ; Tue, 12 Oct 2021 23:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FeQrChfiZcW4o0OhHTmPDOdTdbcOGCmUWNGR2fssds0=; b=YUuG6H1i9AjWoYvXd657AlnL8Btrj3iAYL/kBUykjBQlXgbXqBCSYgFqW+ybNjzAeB flHfU7/d2gVIiRxHZf0let0/mE+C7OG46tBNBXIlx9AYwOAntMTNFSW889cvlMxABatE ibs+ClrRJ9QM6AUZ6rkBA4X98UUtvKEjHgCX4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FeQrChfiZcW4o0OhHTmPDOdTdbcOGCmUWNGR2fssds0=; b=RrmJR548guVPBGsqpIK/+TX5eCr0sq9wkY34YxSlGIPhT63Hl4yMdeoPbn6qTEWSaI Jv9R9CE11U282aPKx7HnTcqFp0FxqkXxV8s3nS/vWHMo/G6gUU6M8fmRRFPpLTSFvXfZ /Cp21aBaZZAJnEL1AZOLXZcSnjUoA46bpjZ7GdKDc8IbG7bNaGzTMC58vmx7SapAw/EN BWsPZTfRYStYjNt9oUPR44Y3yapsGMiBpdQdRo5ab1zPQApGnEWrfHsAvIMNDKcwGYk6 WTxonusnEzqc3jUmhdgGpPOtUA2TS8jJIPFplQwvJQXxEW0h6pu3PsvHgUtHtFXxz2NW xvIA== X-Gm-Message-State: AOAM532I3vMgLVxN3YLEpnwpp8hgo+yYTQ83d3IjD44ZOJ2RWDyo/QaM I6XxckxkfM7E3W3Q1/CJgpYV+w== X-Google-Smtp-Source: ABdhPJwmuFRgBzGEKwhfH80cvrnOY6Q3ng7kI1vOHwrwBDvns1KKcyGoScUlnacdxAU8v7fqrhUUVw== X-Received: by 2002:a63:d654:: with SMTP id d20mr26275164pgj.122.1634105772620; Tue, 12 Oct 2021 23:16:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a28sm13085937pfg.33.2021.10.12.23.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:16:12 -0700 (PDT) Date: Tue, 12 Oct 2021 23:16:11 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 12/29] cramfs: use bdev_nr_sectors instead of open coding it Message-ID: <202110122315.7CFF5F6@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-13-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-13-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_231613_548040_514009C4 X-CRM114-Status: GOOD ( 20.59 ) X-Mailman-Approved-At: Wed, 13 Oct 2021 01:15:58 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:25AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig > --- > fs/cramfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c > index 2be65269a987c..3e44cc3ed0543 100644 > --- a/fs/cramfs/inode.c > +++ b/fs/cramfs/inode.c > @@ -209,7 +209,7 @@ static void *cramfs_blkdev_read(struct super_block *sb, unsigned int offset, > return read_buffers[i] + blk_offset; > } > > - devsize = mapping->host->i_size >> PAGE_SHIFT; > + devsize = bdev_nr_sectors(sb->s_bdev) >> (PAGE_SHIFT - SECTOR_SHIFT); I find this less readable than "bytes >> PAGE_SHIFT". I'd suggest this use a new bdev_nr_bytes() helper. -- Kees Cook _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme