From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
John Levon <levon@movementarian.org>
Subject: Re: [PATCHv2 2/2] nvme-pci: remove cached shadow doorbell offsets
Date: Thu, 14 Oct 2021 18:53:27 +0200 [thread overview]
Message-ID: <20211014165327.GA4148@lst.de> (raw)
In-Reply-To: <20211014164543.1821327-3-kbusch@kernel.org>
On Thu, Oct 14, 2021 at 09:45:43AM -0700, Keith Busch wrote:
> +static bool nvme_dbbuf_update_sq(struct nvme_queue *nvmeq)
> +{
> + struct nvme_dev *dev = nvmeq->dev;
>
> + if (!dev->dbbuf_dbs)
> + return true;
> +
> + return nvme_dbbuf_update_and_check_event(nvmeq->sq_tail,
> + &dev->dbbuf_dbs[sq_idx(nvmeq->qid, dev->db_stride)],
> + &dev->dbbuf_eis[sq_idx(nvmeq->qid, dev->db_stride)]);
> +}
> +
> +static bool nvme_dbbuf_update_cq(struct nvme_queue *nvmeq)
> +{
> + struct nvme_dev *dev = nvmeq->dev;
> +
> + if (!dev->dbbuf_dbs)
> + return true;
> +
> + return nvme_dbbuf_update_and_check_event(nvmeq->cq_head,
> + &dev->dbbuf_dbs[cq_idx(nvmeq->qid, dev->db_stride)],
> + &dev->dbbuf_eis[cq_idx(nvmeq->qid, dev->db_stride)]);
This would look much cleaner with a local variable for the offset.
But otherwise it looks sensible to me.
next prev parent reply other threads:[~2021-10-14 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 16:45 [PATCHv2 0/2] nvme shadow doorbel buf fixes Keith Busch
2021-10-14 16:45 ` [PATCHv2 1/2] nvme-pci: clear shadow doorbell memory on resets Keith Busch
2021-10-14 21:21 ` John Levon
2021-10-20 17:23 ` Christoph Hellwig
2021-10-14 16:45 ` [PATCHv2 2/2] nvme-pci: remove cached shadow doorbell offsets Keith Busch
2021-10-14 16:53 ` Christoph Hellwig [this message]
2021-10-14 17:09 ` John Levon
2021-10-14 17:49 ` Keith Busch
2021-10-14 18:33 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014165327.GA4148@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=levon@movementarian.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox