From: Christoph Hellwig <hch@lst.de>
To: Varun Prakash <varun@chelsio.com>
Cc: sagi@grimberg.me, hch@lst.de, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet-tcp: fix data digest pointer calculation
Date: Wed, 27 Oct 2021 07:57:25 +0200 [thread overview]
Message-ID: <20211027055725.GA9635@lst.de> (raw)
In-Reply-To: <1635182214-3958-1-git-send-email-varun@chelsio.com>
On Mon, Oct 25, 2021 at 10:46:54PM +0530, Varun Prakash wrote:
> exp_ddgst is of type __le32, &cmd->exp_ddgst + cmd->offset
> increases &cmd->exp_ddgst by 4 * cmd->offset, fix this by
> type casting &cmd->exp_ddgst to u8 *.
>
> Fixes: 872d26a391da ("nvmet-tcp: add NVMe over TCP target driver")
> Signed-off-by: Varun Prakash <varun@chelsio.com>
> ---
> drivers/nvme/target/tcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
> index 07ee347..d641bfa 100644
> --- a/drivers/nvme/target/tcp.c
> +++ b/drivers/nvme/target/tcp.c
> @@ -702,7 +702,7 @@ static int nvmet_try_send_ddgst(struct nvmet_tcp_cmd *cmd, bool last_in_batch)
> struct nvmet_tcp_queue *queue = cmd->queue;
> struct msghdr msg = { .msg_flags = MSG_DONTWAIT };
> struct kvec iov = {
> - .iov_base = &cmd->exp_ddgst + cmd->offset,
> + .iov_base = (u8 *)&cmd->exp_ddgst + cmd->offset,
Wouldn't be the better fix to divide cmd->offset by 4 instead of the
casts? I can fix this up inline if that is ok.
next prev parent reply other threads:[~2021-10-27 5:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 17:16 [PATCH] nvmet-tcp: fix data digest pointer calculation Varun Prakash
2021-10-26 13:24 ` Sagi Grimberg
2021-10-27 5:57 ` Christoph Hellwig [this message]
2021-10-27 7:11 ` Sagi Grimberg
2021-10-27 7:13 ` Christoph Hellwig
2021-10-27 9:49 ` Sagi Grimberg
2021-10-27 14:49 ` Varun Prakash
2021-10-28 8:26 ` Sagi Grimberg
2021-10-28 10:49 ` Varun Prakash
2021-10-28 14:00 ` Christoph Hellwig
2021-10-28 14:07 ` Sagi Grimberg
2021-10-27 21:37 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027055725.GA9635@lst.de \
--to=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox