Re: [PATCH V2 1/3] nvmet-tcp: add an helper to free the iovec

Maurizio Lombardi
2021-11-16T09:05:39Z

On Tue, Nov 16, 2021 at 11:00:56AM +0200, Sagi Grimberg wrote:
>
>
> On 11/15/21 6:31 PM, Maurizio Lombardi wrote:
> > Makes the code easier to read and to debug.
> >
> > Sets the freed pointers to NULL, it will be useful
> > when destroying the queues to understand if the
> > iovecs have been released already or not.
> >
> > Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> > ---
> > drivers/nvme/target/tcp.c | 28 +++++++++++++++++++---------
> > 1 file changed, 19 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
> > index 84c387e4bf43..9aa81af84efa 100644
> > --- a/drivers/nvme/target/tcp.c
> > +++ b/drivers/nvme/target/tcp.c
> > @@ -166,6 +166,8 @@ static struct workqueue_struct *nvmet_tcp_wq;
> > static const struct nvmet_fabrics_ops nvmet_tcp_ops;
> > static void nvmet_tcp_free_cmd(struct nvmet_tcp_cmd *c);
> > static void nvmet_tcp_finish_cmd(struct nvmet_tcp_cmd *cmd);
> > +static void nvmet_tcp_free_iovec(struct nvmet_tcp_cmd *cmd);
> > +static void nvmet_tcp_unmap_pdu_iovec(struct nvmet_tcp_cmd *cmd);
> > static inline u16 nvmet_tcp_cmd_tag(struct nvmet_tcp_queue *queue,
> > struct nvmet_tcp_cmd *cmd)
> > @@ -297,6 +299,16 @@ static int nvmet_tcp_check_ddgst(struct nvmet_tcp_queue *queue, void *pdu)
> > return 0;
> > }
> > +static void nvmet_tcp_free_iovec(struct nvmet_tcp_cmd *cmd)
>
> I'd call it nvmet_tcp_free_cmd_buffers maybe. It is freeing
> both the data buffers, sgl vector and iovec.

Ok no problem for me, I will resubmit it.

Thanks,
Maurizio