From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 2/5] blk-mq: rename hctx_lock & hctx_unlock
Date: Mon, 22 Nov 2021 10:00:31 +0100 [thread overview]
Message-ID: <20211122090031.GA28870@lst.de> (raw)
In-Reply-To: <20211119021849.2259254-3-ming.lei@redhat.com>
On Fri, Nov 19, 2021 at 10:18:46AM +0800, Ming Lei wrote:
> +static inline void queue_unlock(struct request_queue *q, bool blocking,
> + int srcu_idx)
I don't think this is a good name, as it can be easily confused with
q->queue_lock.
> + __releases(q->srcu)
> {
> - if (!(hctx->flags & BLK_MQ_F_BLOCKING))
> + if (!blocking)
> rcu_read_unlock();
> else
> - srcu_read_unlock(hctx->queue->srcu, srcu_idx);
> + srcu_read_unlock(q->srcu, srcu_idx);
> }
I think you want to make BLK_MQ_F_BLOCKING accessible from the
request_queue instead of passing the extra argument as well.
next prev parent reply other threads:[~2021-11-22 9:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 2:18 [PATCH 0/5] blk-mq: quiesce improvement Ming Lei
2021-11-19 2:18 ` [PATCH 1/5] blk-mq: move srcu from blk_mq_hw_ctx to request_queue Ming Lei
2021-11-19 4:30 ` Bart Van Assche
2021-11-19 8:10 ` Ming Lei
2021-11-22 7:48 ` Sagi Grimberg
2021-11-22 13:08 ` Ming Lei
2021-11-22 13:47 ` Sagi Grimberg
2021-11-19 2:18 ` [PATCH 2/5] blk-mq: rename hctx_lock & hctx_unlock Ming Lei
2021-11-22 7:53 ` Sagi Grimberg
2021-11-22 13:20 ` Ming Lei
2021-11-22 13:50 ` Sagi Grimberg
2021-11-23 0:08 ` Ming Lei
2021-11-23 8:54 ` Sagi Grimberg
2021-11-22 9:00 ` Christoph Hellwig [this message]
2021-11-19 2:18 ` [PATCH 3/5] blk-mq: add helper of blk_mq_global_quiesce_wait() Ming Lei
2021-11-22 7:56 ` Sagi Grimberg
2021-11-22 8:00 ` Sagi Grimberg
2021-11-22 13:26 ` Ming Lei
2021-11-22 13:55 ` Sagi Grimberg
2021-11-23 0:17 ` Ming Lei
2021-11-23 9:00 ` Sagi Grimberg
2021-11-30 2:33 ` Ming Lei
2021-12-08 12:49 ` Sagi Grimberg
2021-12-10 2:02 ` Ming Lei
2021-11-19 2:18 ` [PATCH 4/5] nvme: quiesce namespace queue in parallel Ming Lei
2021-11-22 8:07 ` Sagi Grimberg
2021-11-23 0:13 ` Ming Lei
2021-11-19 2:18 ` [PATCH 5/5] scsi: use blk-mq quiesce APIs to implement scsi_host_block Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122090031.GA28870@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox