From: Varun Prakash <varun@chelsio.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: hch@lst.de, kbusch@kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3 2/2] nvme-tcp: send H2CData PDUs based on MAXH2CDATA
Date: Tue, 23 Nov 2021 21:11:18 +0530 [thread overview]
Message-ID: <20211123154117.GA1714@chelsio.com> (raw)
In-Reply-To: <3b3a65a7-0885-0dc9-e78f-ac8a8c04a646@grimberg.me>
On Tue, Nov 23, 2021 at 02:58:05PM +0200, Sagi Grimberg wrote:
> >@@ -633,14 +640,19 @@ static int nvme_tcp_handle_r2t(struct nvme_tcp_queue *queue,
> > return -EPROTO;
> > }
> >- if (unlikely(le32_to_cpu(pdu->r2t_offset) < req->data_sent)) {
> >+ if (unlikely(r2t_offset < req->data_sent)) {
> > dev_err(queue->ctrl->ctrl.device,
> > "req %d unexpected r2t offset %u (expected %zu)\n",
> >- rq->tag, le32_to_cpu(pdu->r2t_offset), req->data_sent);
> >+ rq->tag, r2t_offset, req->data_sent);
> > return -EPROTO;
> > }
> >- nvme_tcp_setup_h2c_data_pdu(req, pdu);
> >+ req->pdu_len = 0;
>
> Why do you need to set this here? it is set in the initial command
> execution...
This is needed for multiple R2T case.
next prev parent reply other threads:[~2021-11-23 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 10:59 [PATCH v3 2/2] nvme-tcp: send H2CData PDUs based on MAXH2CDATA Varun Prakash
2021-11-23 12:58 ` Sagi Grimberg
2021-11-23 15:41 ` Varun Prakash [this message]
2021-11-23 20:00 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123154117.GA1714@chelsio.com \
--to=varun@chelsio.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox