From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: print out valid arguments when reading from /dev/nvme-fabrics
Date: Tue, 23 Nov 2021 17:22:04 +0100 [thread overview]
Message-ID: <20211123162204.GB23957@lst.de> (raw)
In-Reply-To: <20211119083912.38260-1-hare@suse.de>
The subject should use a nvme-fabrics prefix.
> + const struct match_token *tok;
> + int idx;
> +
> + for (idx = 0; idx < ARRAY_SIZE(opt_tokens); idx++) {
> + tok = &opt_tokens[idx];
> + if (tok->token == NVMF_OPT_ERR)
> + continue;
> + if (idx)
> + seq_puts(seq_file, ",");
> + seq_puts(seq_file, tok->pattern);
> + }
> + seq_puts(seq_file, "\n");
A helper for this logic would be nice. Also shouldn't be there
some kind of token to distinguish from the case where a controller
has already been created?
next prev parent reply other threads:[~2021-11-23 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 8:39 [PATCH] nvme: print out valid arguments when reading from /dev/nvme-fabrics Hannes Reinecke
2021-11-23 8:39 ` Chaitanya Kulkarni
2021-11-23 16:22 ` Christoph Hellwig [this message]
2021-11-23 16:38 ` Hannes Reinecke
2021-11-23 16:42 ` Christoph Hellwig
2021-11-23 17:03 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123162204.GB23957@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox