From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
mgurtovoy@nvidia.com
Subject: Re: [PATCHv3 4/4] nvme-pci: fix queue_rqs list splitting
Date: Wed, 5 Jan 2022 19:18:56 +0100 [thread overview]
Message-ID: <20220105181856.GC12168@lst.de> (raw)
In-Reply-To: <20220105170518.3181469-5-kbusch@kernel.org>
On Wed, Jan 05, 2022 at 09:05:18AM -0800, Keith Busch wrote:
> If command prep fails, current handling will orphan subsequent requests
> in the list. Consider a simple example:
>
> rqlist = [ 1 -> 2 ]
>
> When prep for request '1' fails, it will be appended to the
> 'requeue_list', leaving request '2' disconnected from the original
> rqlist and no longer tracked. Meanwhile, rqlist is still pointing to the
> failed request '1' and will attempt to submit the unprepped command.
>
> Fix this by updating the rqlist accordingly using the request list
> helper functions.
>
> Fixes: d62cbcf62f2f ("nvme: add support for mq_ops->queue_rqs()")
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-01-05 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 17:05 [PATCHv3 0/4] queue_rqs error handling Keith Busch
2022-01-05 17:05 ` [PATCHv3 1/4] block: move rq_list macros to blk-mq.h Keith Busch
2022-01-05 18:17 ` Christoph Hellwig
2022-01-05 17:05 ` [PATCHv3 2/4] block: introduce rq_list_for_each_safe macro Keith Busch
2022-01-05 17:05 ` [PATCHv3 3/4] block: introduce rq_list_move Keith Busch
2022-01-05 18:18 ` Christoph Hellwig
2022-01-05 17:05 ` [PATCHv3 4/4] nvme-pci: fix queue_rqs list splitting Keith Busch
2022-01-05 18:18 ` Christoph Hellwig [this message]
2022-01-05 19:25 ` [PATCHv3 0/4] queue_rqs error handling Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105181856.GC12168@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).