From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01EC6C433EF for ; Tue, 18 Jan 2022 09:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ESkxugrDF83AuiVooYHxdhni2Li70FsJ1JzGYWnbrh0=; b=la3MCFjt/BfdGPDiG9uD0ylCHY 2xpXeWUuW4UAEa8ANSbodtzxkm1NAZG1OX2JHt9mrR8sChMEq4zoBW8iw43cKqTiVtKLvrzOkGCGQ s6SbLkJBrRm8GMiAzm8Zrkg3I+zmHMWu0UeJivCJSLrq276Ac3xK978SQpGaOaS68jdDvHANBjqz0 PvWEnF+M66Jrc/nZ5+xiZbnhi4cEsGanXUCrg7Zw75UtzcInGVX8yc3SibUGgxSRm0AqDGmqOTw54 F8G2nNdgWYDuFJ4c99vil2ofFuSzQTroSJxb3QaqtlGf177RIlatROle1ssqpP9cpw+l+GBFvSZCg tzShvgXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9klH-000ttF-CW; Tue, 18 Jan 2022 09:26:43 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9klA-000trp-7Y for linux-nvme@lists.infradead.org; Tue, 18 Jan 2022 09:26:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642497996; x=1674033996; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ripv7PKf8AE+DZencjgRj4jyC+vbpn4HOU9gpa3R3nI=; b=HQcRIVdcNrLhFlh/bqEqMCtx1NKNHjI7ZPe9fU4HhajzOwlYFZF3pOX2 K5Lrvn9xEw7s0KftXT4OJN7J2Ili7vBzEA9AwfVsyU+5WtAguQ+edFC2U tBM3+fKXdwOhff4EuPc3jHnwEYfr7XtYOcIDijQn+AGrzNhADIHhHUT0b Av/lCNDUayddhpxzbPDENKG2gN80qKia/P7kUc1A8bk0N0eN6kmMj1vTc 0xVwZ4EjldWQwclDyIK73aC7BiaFM0jl3hRqBVN+HQ8YrUHv7xaijZ2Cg 9xblYHX+vUEWUwKa0MqhxLeUsHbcw1FZ0f1FxN9ROxQBwtR4mPlKrm7y8 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="243598712" X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="243598712" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 01:26:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="578339881" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 18 Jan 2022 01:26:09 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1n9kkj-000CPD-AO; Tue, 18 Jan 2022 09:26:09 +0000 Date: Tue, 18 Jan 2022 17:25:31 +0800 From: kernel test robot To: Hannes Reinecke Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Chaitanya Kulkarni , Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: [PATCH] nvme-fabrics: fix returnvar.cocci warnings Message-ID: <20220118092531.GA25410@95126676e75f> References: <202201181710.TjfwKXN9-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202201181710.TjfwKXN9-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_012636_322741_45FC0352 X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: kernel test robot drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") CC: Hannes Reinecke Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e3a8b6a1e70c37702054ae3c7c07ed828435d8ee commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics :::::: branch date: 5 hours ago :::::: commit date: 4 weeks ago fabrics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str static int nvmf_dev_show(struct seq_file *seq_file, void *private) { struct nvme_ctrl *ctrl; - int ret = 0; mutex_lock(&nvmf_dev_mutex); ctrl = seq_file->private; @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file out_unlock: mutex_unlock(&nvmf_dev_mutex); - return ret; + return 0; } static int nvmf_dev_open(struct inode *inode, struct file *file)