From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9FC8C433F5 for ; Mon, 24 Jan 2022 12:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5lpLvhIRCTb7CzAJnGLvbrygiv7yuiPP7WOuxfhIYus=; b=E0+YGH8GY9O8iCUvbGNbPVfPa1 Jy0sXdMyvHbWTI+CTrVljqD9yyiVEyGfnNw3u8WpU8yoecHThrL5GeO8BXGpwRQTxtxvilUTiXU7Y PKMBPc7jv/dIj5HOWbqQoC+dwJAn+zKY/oOD5GJTbl2X6AnZZx8bXdIVeDN61zqWPOwixLo5kXyIu 6uyg+ukV5HkemU9cn4QAJgZgampICAVEy3XM14K0tr1hOAxbiYYj0vWxZSRMRJGcqaaStJn03uEvG w/bmT0EvUMTz7ogRwpSd7OdXIzB4y+rJ4MghXYpJqmjjxkVKFqKxvPSJgOB3u4bwo4WeKF6S4K4o2 CfHW8qrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBywc-003Lpb-Nk; Mon, 24 Jan 2022 12:59:38 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBywW-003Lng-IS for linux-nvme@lists.infradead.org; Mon, 24 Jan 2022 12:59:34 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0236968C4E; Mon, 24 Jan 2022 13:59:27 +0100 (CET) Date: Mon, 24 Jan 2022 13:59:27 +0100 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , "Martin K . Petersen" , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH V2 01/13] block: declare blkcg_[init|exit]_queue in private header Message-ID: <20220124125927.GA27269@lst.de> References: <20220122111054.1126146-1-ming.lei@redhat.com> <20220122111054.1126146-2-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220122111054.1126146-2-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_045932_777308_9266F161 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sat, Jan 22, 2022 at 07:10:42PM +0800, Ming Lei wrote: > Both two functions are used by block core code only, so move the > declaration into private header of block layer. Hmm. Given how much of blk-cgroup.h is private I wonder if moving most of it to block/blk-cgroup.h and just keeping a small public header might be a better idea.