From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55A46C433F5 for ; Tue, 25 Jan 2022 16:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iSdun2irPKtKrKsOegGB+RSB68szwX/DaPrpol+U0Us=; b=QPZuKyFwh9E3Fpj4lbq7zblxbw MZEb9whcdx6ZWlOFx7MgNa4i+GTYunHtYbd96lhGBTBt951VPPSl556LGlogQ0i/wBo9AbP2750rM Km17Hk3dZwxy5cJJFXorTHM1AsW1kUA5qCWfJjpMIpKccbbGbpMFu9KlarT7LmvKeTDkSsWBrathb MXdIl0P6BWQT9AsOgSLews0IQfptRXAj6OrAIOwaOm7uMsQUN75qOQQXsE79fcB/3DQOHkQs9WRVU qgrO/chAeHm4K6ds0NURTZnxAHL4sSgV5Q/2leVZgKw2/TTzS1bC/zFu7kCVAsKd+yFGmTF3zrKUn HJPUdGgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCOXi-008diz-CF; Tue, 25 Jan 2022 16:19:38 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCOSu-008blB-Bl for linux-nvme@lists.infradead.org; Tue, 25 Jan 2022 16:14:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643127280; x=1674663280; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZhVMjcdlxj873VdA6sEVIlWL3XJpbJPYkvwqeD4zZWU=; b=M+DprX0Yznw+rxJklgwJGaAMXvZSU5y/LrFgwz3Bq8HtGTVxP3pnAS/q rTJNcldciUi8V3qoXGZs8Hw4qYpnvG1F2DnTdv0KPHm0P5gPaQqjR1/OT tpqTm3FFva80CUTKAFx3so6hJ8bS2mePDCzk9m+/qXoHh8z1AYVjhMJ7f FJhsqxMGMd6+TkpJlRVchLBgFI/U5gwFQ5vdaiRjAalrhM2THwc45ZsD3 vtdkZeyD4UivM3TVZQGI5lZXpfCU6/QNwk+w5LWJo7gn9AovFAXvPIYTJ cfPfEGTR6t/yxGuy9H8A9UvVnRtR1ZgdWFXo6RXN4I9PbUvfpHA6WDF9W A==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="243937626" X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="243937626" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 08:13:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="495043769" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 25 Jan 2022 08:13:05 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nCORN-000K85-Aq; Tue, 25 Jan 2022 16:13:05 +0000 Date: Wed, 26 Jan 2022 00:12:11 +0800 From: kernel test robot To: Hannes Reinecke Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Chaitanya Kulkarni , Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: [PATCH] nvme-fabrics: fix returnvar.cocci warnings Message-ID: <20220125161210.GA42603@d3bbc358300d> References: <202201260046.otELTDdH-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202201260046.otELTDdH-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_081440_495720_6E78D201 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: kernel test robot drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") CC: Hannes Reinecke Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a08b41ab9e2e468647f78eb17c28e29b93006394 commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics :::::: branch date: 10 hours ago :::::: commit date: 5 weeks ago fabrics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str static int nvmf_dev_show(struct seq_file *seq_file, void *private) { struct nvme_ctrl *ctrl; - int ret = 0; mutex_lock(&nvmf_dev_mutex); ctrl = seq_file->private; @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file out_unlock: mutex_unlock(&nvmf_dev_mutex); - return ret; + return 0; } static int nvmf_dev_open(struct inode *inode, struct file *file)