From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: hch@lst.de, kbusch@kernel.org, axboe@kernel.dk, kch@nvidia.com,
linux-nvme@lists.infradead.org, joshiiitr@gmail.com
Subject: Re: [PATCH v2] nvme: add vectored-io support for user-passthru
Date: Tue, 1 Feb 2022 09:02:02 +0100 [thread overview]
Message-ID: <20220201080202.GA29518@lst.de> (raw)
In-Reply-To: <20220131141847.4791-1-joshi.k@samsung.com>
> +static int nvme_user_cmd64(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> + struct nvme_passthru_cmd64 __user *ucmd)
> +{
> + return nvme_user_cmd64_common(ctrl, ns, ucmd, false);
> +}
> +
> +static int nvme_user_cmd64_vec(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> + struct nvme_passthru_cmd64 __user *ucmd)
> +{
> + return nvme_user_cmd64_common(ctrl, ns, ucmd, true);
> }
I think we cn skip these tiny wrappers.
> static bool is_ctrl_ioctl(unsigned int cmd)
> @@ -341,6 +369,8 @@ static int nvme_ns_ioctl(struct nvme_ns *ns, unsigned int cmd,
> return nvme_submit_io(ns, argp);
> case NVME_IOCTL_IO64_CMD:
> return nvme_user_cmd64(ns->ctrl, ns, argp);
> + case NVME_IOCTL_IO64_CMD_VEC:
> + return nvme_user_cmd64_vec(ns->ctrl, ns, argp);
Maybe add a rationale why we don't need a new ioctl for admin
commands to the commit log.
next prev parent reply other threads:[~2022-02-01 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220131142354epcas5p3ff940846a88ae6fcfd8f9b3acb421913@epcas5p3.samsung.com>
2022-01-31 14:18 ` [PATCH v2] nvme: add vectored-io support for user-passthru Kanchan Joshi
2022-02-01 8:02 ` Christoph Hellwig [this message]
2022-02-02 6:52 ` Kanchan Joshi
2022-02-02 7:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201080202.GA29518@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=joshi.k@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).