From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org,
sagi@grimberg.me, Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 1/9] nvme-fc: add a helper to initialize connect_q
Date: Tue, 1 Feb 2022 09:09:34 +0100 [thread overview]
Message-ID: <20220201080934.GA29769@lst.de> (raw)
In-Reply-To: <20220128092015.19289-2-chaitanyak@nvidia.com>
On Fri, Jan 28, 2022 at 01:20:07AM -0800, Chaitanya Kulkarni wrote:
> +static inline int nvme_ctrl_init_connect_q(struct nvme_ctrl *ctrl)
> +{
> + ctrl->connect_q = blk_mq_init_queue(ctrl->tagset);
> + if (IS_ERR(ctrl->connect_q))
> + return PTR_ERR(ctrl->connect_q);
> + return 0;
> +}
This should be out of line in fabrics.c.
Also I'd prefer one patch to switch everyone to the helper in this
case.
next prev parent reply other threads:[~2022-02-01 8:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 9:20 [PATCH 0/9] nvme: add helpers and remove duplicate code Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 1/9] nvme-fc: add a helper to initialize connect_q Chaitanya Kulkarni
2022-01-28 9:23 ` Chaitanya Kulkarni
2022-01-30 9:44 ` Sagi Grimberg
2022-02-01 8:09 ` Christoph Hellwig [this message]
2022-01-28 9:20 ` [PATCH 2/9] nvme-rdma: use " Chaitanya Kulkarni
2022-01-30 9:44 ` Sagi Grimberg
2022-01-28 9:20 ` [PATCH 3/9] nvme-tcp: " Chaitanya Kulkarni
2022-01-30 9:44 ` Sagi Grimberg
2022-01-28 9:20 ` [PATCH 4/9] nvme-loop: " Chaitanya Kulkarni
2022-01-30 9:44 ` Sagi Grimberg
2022-01-28 9:20 ` [PATCH 5/9] nvme-fc: centralize admin tagset initialization Chaitanya Kulkarni
2022-01-28 9:23 ` Chaitanya Kulkarni
2022-01-30 9:47 ` Sagi Grimberg
2022-02-02 6:48 ` Chaitanya Kulkarni
2022-02-01 8:11 ` Christoph Hellwig
2022-02-02 6:46 ` Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 6/9] nvme-pci: use helper for " Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 7/9] nvme-rdma: " Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 8/9] nvme-tcp: " Chaitanya Kulkarni
2022-01-28 9:20 ` [PATCH 9/9] nvme-loop: " Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201080934.GA29769@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).