From: Uday Shankar <ushankar@purestorage.com>
To: stable@vger.kernel.org
Cc: Prabhath Sajeepa <psajeepa@purestorage.com>,
linux-nvme@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
Uday Shankar <ushankar@purestorage.com>
Subject: Apply "nvme: Fix parsing of ANA log page" to 5.4
Date: Wed, 9 Feb 2022 17:17:21 -0700 [thread overview]
Message-ID: <20220210001721.GA151884@dev-ushankar.dev.purestorage.com> (raw)
Hello,
Please apply the patch "nvme: Fix parsing of ANA log page" to 5.4.
The commit ID in Linus's tree is:
64fab7290dc3561729bbc1e35895a517eb2e549e
The patch was originally submitted on the linux-nvme mailing list, but
for reasons unknown to me it never landed on 5.4 - this thread indicates
it should have been accepted for 5.4.
https://lore.kernel.org/linux-nvme/1572303408-37913-1-git-send-email-psajeepa@purestorage.com/T/#u
Without the patch, we perform the check
WARN_ON_ONCE(offset > ctrl->ana_log_size - sizeof(*desc))
at the end of the enclosing loop. This check only makes sense if we are
about to read another nvme_ana_group_desc from the ana_log_buf, but
that's not the case at the end of the last iteration of the loop. In the
last iteration, the warning fires and the function nvme_parse_ana_log
fails. When nvme native multipath is enabled, this translates into
failure to establish a connection to the controller.
The patch fixes the issue by moving the above check to a correct
position within the loop body.
Thanks,
Uday Shankar
next reply other threads:[~2022-02-10 0:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 0:17 Uday Shankar [this message]
2022-02-11 11:29 ` Apply "nvme: Fix parsing of ANA log page" to 5.4 Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210001721.GA151884@dev-ushankar.dev.purestorage.com \
--to=ushankar@purestorage.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-nvme@lists.infradead.org \
--cc=psajeepa@purestorage.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox