Re: [PATCH 17/17] nvme: enable non-inline passthru commands

Jens Axboe
2022-04-01T01:23:47Z

On 3/30/22 7:02 AM, Christoph Hellwig wrote:
> On Fri, Mar 25, 2022 at 07:09:21PM +0530, Kanchan Joshi wrote:
>> Ok. If you are open to take new opcode/struct route, that is all we
>> require to pair with big-sqe and have this sorted. How about this -
>
> I would much, much, much prefer to support a bigger CQE. Having
> a pointer in there just creates a fair amount of overhead and
> really does not fit into the model nvme and io_uring use.
>
> But yes, if we did not go down that route that would be the structure
> that is needed.

IMHO doing 32-byte CQEs is the only sane choice here, I would not
entertain anything else.

--
Jens Axboe