From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7659EC433EF for ; Mon, 14 Mar 2022 07:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h3OVs8VkpAOF55fUXWfIN6cJdPQj7DwOw054WxdAUzo=; b=UWSETwnqvGwzth+R6BIIuqRjrq NQb8QlRG1eU4Y9/ukIYvoCk9P5j42NltC3GfVIOKN9wldA1PJWueHeOB5goqRnO/lr8ErMVonb8G/ 44FPpTaWhj5U4eOvWY0puATxCOVSaExqT0Odcmg3h2/ladRpW4tqAshxAOKwqKIQddpkl1amggJKR 5UbDV+jQNibjkgae5q8UtFtl9bPeldFyv198XcH4+OXGP25yBiYujKK3lwSSlRyJLQzM+VZ2NyMZ3 kAb/JptPMPHxqNHyRfQ4cjJTk7J3UVqlq5ql36QjUsXPRQxpSPoX77ZhGRRHir6XHz6ADaKuYZ4zi EbjF4mxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTezl-0042rR-72; Mon, 14 Mar 2022 07:19:57 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTezj-0042qk-0z for linux-nvme@lists.infradead.org; Mon, 14 Mar 2022 07:19:56 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BDD0E68AFE; Mon, 14 Mar 2022 08:19:50 +0100 (CET) Date: Mon, 14 Mar 2022 08:19:50 +0100 From: Christoph Hellwig To: Mingbao Sun Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Dumazet , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , netdev@vger.kernel.org, tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com, libin.zhang@dell.com, ao.sun@dell.com Subject: Re: [PATCH v2 2/3] nvme-tcp: support specifying the congestion-control Message-ID: <20220314071950.GA4059@lst.de> References: <20220311103414.8255-1-sunmingbao@tom.com> <20220311103414.8255-2-sunmingbao@tom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220311103414.8255-2-sunmingbao@tom.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_001955_239464_54EA173B X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org The implementation of this and the target side looks sane to me. I'll wait for the opinion of the NVMe/TCP on the usefulness of this, and for the networking maintainer on an ACK for patch 1.