public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <keith.busch@wdc.com>,
	linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: [RFC PATCH 0/3] nvmet: export discovery subsystem
Date: Mon, 14 Mar 2022 11:53:30 +0100	[thread overview]
Message-ID: <20220314105333.56714-1-hare@suse.de> (raw)

Hi all,

here's a patchset to expose the discovery subsystem in configfs.
The current implementation is has a rather 'odd' discovery subsystem
implementation; there is one discovery subsystem structure, but the
details of this subsystem will be modified depending from which port
(and, consequently, port->subsystem link) is has been called.
This makes is really awkward to assign unique properties to it
(like the unique discovery NQN).

With this patchset the discovery subsystem is elevated to a 'real'
subsystem, with a normal subsystem entry in sysfs and with activation
of it by linking this subsystem to ports.
This gives full control to the user which subsystem should be visible
on this discovery controller, and also allows to have a discovery
controller with no I/O subsystems at all.

Drawback is that it's a change in operation, as the user _has_ to
link the subsystem to individual ports.

As usual, comments and reviews are welcome.

Hannes Reinecke (3):
  nvmet: expose discovery subsystem in sysfs
  nvmet: restrict setting of discovery_nqn to discovery subsystem
  nvmet: do not allow to create a subsystem with the discovery NQN

 drivers/nvme/target/configfs.c  | 46 +++++++++++++++++++++++++++++----
 drivers/nvme/target/core.c      |  1 +
 drivers/nvme/target/discovery.c |  7 +----
 3 files changed, 43 insertions(+), 11 deletions(-)

-- 
2.29.2



             reply	other threads:[~2022-03-14 10:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 10:53 Hannes Reinecke [this message]
2022-03-14 10:53 ` [PATCH 1/3] nvmet: expose discovery subsystem in sysfs Hannes Reinecke
2022-03-15  8:06   ` Christoph Hellwig
2022-03-15  8:40     ` Sagi Grimberg
2022-03-15  9:06       ` Hannes Reinecke
2022-03-15  9:49         ` Christoph Hellwig
2022-03-15 10:23           ` Sagi Grimberg
2022-03-15 10:38           ` Hannes Reinecke
2022-03-15 10:49             ` Sagi Grimberg
2022-03-15 11:09               ` Hannes Reinecke
2022-03-15 11:15                 ` Sagi Grimberg
2022-03-15 12:51                   ` Hannes Reinecke
2022-03-15 13:48                     ` Sagi Grimberg
2022-03-23 17:17           ` John Meneghini
2022-03-23 17:23             ` Christoph Hellwig
2022-03-23 17:52               ` John Meneghini
2022-03-23 17:34             ` Knight, Frederick
2022-03-23 18:03               ` John Meneghini
2022-03-23 18:07                 ` Knight, Frederick
2022-03-14 10:53 ` [PATCH 2/3] nvmet: restrict setting of discovery_nqn to discovery subsystem Hannes Reinecke
2022-03-15  8:09   ` Christoph Hellwig
2022-03-15  8:57     ` Sagi Grimberg
2022-03-15  9:00       ` Christoph Hellwig
2022-03-24  0:52         ` John Meneghini
2022-03-24  1:46           ` John Meneghini
2022-03-14 10:53 ` [PATCH 3/3] nvmet: do not allow to create a subsystem with the discovery NQN Hannes Reinecke
2022-03-15  8:10   ` Christoph Hellwig
2022-03-15  8:45     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220314105333.56714-1-hare@suse.de \
    --to=hare@suse.de \
    --cc=hch@lst.de \
    --cc=keith.busch@wdc.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox