From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/3] nvmet: do not allow to create a subsystem with the discovery NQN
Date: Tue, 15 Mar 2022 09:10:13 +0100 [thread overview]
Message-ID: <20220315081013.GC3082@lst.de> (raw)
In-Reply-To: <20220314105333.56714-4-hare@suse.de>
On Mon, Mar 14, 2022 at 11:53:33AM +0100, Hannes Reinecke wrote:
> configfs will only protect us against duplication of subsystem NQNs,
> but discovery subsystems might have two NQNs, the standard discovery NQN
> (which will be used as the configfs directory name), and the additional
> unique subsystem NQN.
This is something that we should probably pick up as fix ASAP. Can
you add a proper fixes tag and submit it stand-alone?
next prev parent reply other threads:[~2022-03-15 8:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 10:53 [RFC PATCH 0/3] nvmet: export discovery subsystem Hannes Reinecke
2022-03-14 10:53 ` [PATCH 1/3] nvmet: expose discovery subsystem in sysfs Hannes Reinecke
2022-03-15 8:06 ` Christoph Hellwig
2022-03-15 8:40 ` Sagi Grimberg
2022-03-15 9:06 ` Hannes Reinecke
2022-03-15 9:49 ` Christoph Hellwig
2022-03-15 10:23 ` Sagi Grimberg
2022-03-15 10:38 ` Hannes Reinecke
2022-03-15 10:49 ` Sagi Grimberg
2022-03-15 11:09 ` Hannes Reinecke
2022-03-15 11:15 ` Sagi Grimberg
2022-03-15 12:51 ` Hannes Reinecke
2022-03-15 13:48 ` Sagi Grimberg
2022-03-23 17:17 ` John Meneghini
2022-03-23 17:23 ` Christoph Hellwig
2022-03-23 17:52 ` John Meneghini
2022-03-23 17:34 ` Knight, Frederick
2022-03-23 18:03 ` John Meneghini
2022-03-23 18:07 ` Knight, Frederick
2022-03-14 10:53 ` [PATCH 2/3] nvmet: restrict setting of discovery_nqn to discovery subsystem Hannes Reinecke
2022-03-15 8:09 ` Christoph Hellwig
2022-03-15 8:57 ` Sagi Grimberg
2022-03-15 9:00 ` Christoph Hellwig
2022-03-24 0:52 ` John Meneghini
2022-03-24 1:46 ` John Meneghini
2022-03-14 10:53 ` [PATCH 3/3] nvmet: do not allow to create a subsystem with the discovery NQN Hannes Reinecke
2022-03-15 8:10 ` Christoph Hellwig [this message]
2022-03-15 8:45 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315081013.GC3082@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox