From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ED18C433F5 for ; Wed, 30 Mar 2022 13:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TuyL5Jrc8+fQpsw+dO55DQFMoSZFQgJ10fx0QCEjKrw=; b=Z4lTdjlhX/2Err+6FK3cBM1+ap XluiHk58efJR5IiwEFsL2Hm18WubwHeQdx0S/VqJjH6Bt+jix1hEsTiFfOWoQuygtbf0WuWX/1rkf 0Aw8Mr5YG1cMHWjmeNuD5Kwt2MmoyFRtLznt5aIFeQdlJVJpIhkMYllVDvY1rimkHCiVlbJUeJYBh uI3i+s8bph+WKOnITddHRfL/Eg9CMgyeI/ESlHe3CLOXzqa4HQwXAFqJGj6/j3pEkPD2oIL47Wukr AumgHWiFD1z2y3EiK/EsTwHc0VTlSO26waoNmHbetLZ4N7wgkWEu66Vl7COfWrurI1zhBZY4zpnLa zaGoNqQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZXy0-00Fx9V-UT; Wed, 30 Mar 2022 13:02:29 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZXxw-00Fx6K-24 for linux-nvme@lists.infradead.org; Wed, 30 Mar 2022 13:02:25 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0138368AA6; Wed, 30 Mar 2022 15:02:20 +0200 (CEST) Date: Wed, 30 Mar 2022 15:02:19 +0200 From: Christoph Hellwig To: Kanchan Joshi Cc: Christoph Hellwig , Kanchan Joshi , Jens Axboe , Keith Busch , Pavel Begunkov , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, sbates@raithlin.com, logang@deltatee.com, Pankaj Raghav , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Luis Chamberlain , Adam Manzanares , Anuj Gupta Subject: Re: [PATCH 17/17] nvme: enable non-inline passthru commands Message-ID: <20220330130219.GB1938@lst.de> References: <20220308152105.309618-18-joshi.k@samsung.com> <20220310083652.GF26614@lst.de> <20220310141945.GA890@lst.de> <20220311062710.GA17232@lst.de> <20220324063218.GC12660@lst.de> <20220325133921.GA13818@test-zns> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220325133921.GA13818@test-zns> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220330_060224_300040_45626BA5 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Mar 25, 2022 at 07:09:21PM +0530, Kanchan Joshi wrote: > Ok. If you are open to take new opcode/struct route, that is all we > require to pair with big-sqe and have this sorted. How about this - I would much, much, much prefer to support a bigger CQE. Having a pointer in there just creates a fair amount of overhead and really does not fit into the model nvme and io_uring use. But yes, if we did not go down that route that would be the structure that is needed.