From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/3] nvmet: check for subsystem type in nvmet_find_get_subsys()
Date: Tue, 5 Apr 2022 08:07:42 +0200 [thread overview]
Message-ID: <20220405060742.GA24073@lst.de> (raw)
In-Reply-To: <1c44e4aa-f966-5767-a147-a7f24f6753ee@suse.de>
On Tue, Apr 05, 2022 at 07:53:43AM +0200, Hannes Reinecke wrote:
> Do we want to support unique discovery controller NQNs in nvmet?
>
> Previously there was a rather strict policy of implementing only the bare
> necessities in nvmet, and unique discovery controller NQNs is arguably not
> a necessary thing.
I don't think there has ever been a policy of only bare necessities. But
more one of checking if features are useful for nvmet.
Given that we basically need unique discovery controllers to usefull
support authentication it seems like we have to support them, even if the
feature on its down does not look all that useful.
next prev parent reply other threads:[~2022-04-05 6:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 14:26 [PATCHv2 0/3] nvmet: unique discovery subsystem Hannes Reinecke
2022-03-17 14:26 ` [PATCH 1/3] nvmet: check for subsystem type in nvmet_find_get_subsys() Hannes Reinecke
2022-04-05 5:45 ` Christoph Hellwig
2022-04-05 5:53 ` Hannes Reinecke
2022-04-05 6:07 ` Christoph Hellwig [this message]
2022-04-05 13:06 ` John Meneghini
2022-03-17 14:26 ` [PATCH 2/3] nvmet: make the subsystem type configurable Hannes Reinecke
2022-04-05 5:47 ` Christoph Hellwig
2022-04-05 6:00 ` Hannes Reinecke
2022-04-05 6:09 ` Christoph Hellwig
2022-04-05 6:29 ` Hannes Reinecke
2022-04-05 10:35 ` Sagi Grimberg
2022-04-05 11:12 ` Hannes Reinecke
2022-04-05 15:02 ` John Meneghini
2022-04-05 13:15 ` John Meneghini
2022-03-17 14:26 ` [PATCH 3/3] nvmet: include all configured ports in discovery log page for unique discover controller Hannes Reinecke
2022-04-05 5:46 ` Christoph Hellwig
2022-04-05 6:15 ` Hannes Reinecke
2022-04-05 6:19 ` Christoph Hellwig
2022-04-05 6:35 ` Hannes Reinecke
2022-04-05 7:31 ` Christoph Hellwig
2022-04-05 10:32 ` Sagi Grimberg
2022-04-05 15:09 ` John Meneghini
2022-04-06 11:39 ` Hannes Reinecke
2022-04-05 10:41 ` Sagi Grimberg
2022-04-05 11:01 ` Hannes Reinecke
2022-04-05 14:22 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2022-03-17 13:18 [PATCH 0/3] nvmet: unique discovery subsystem Hannes Reinecke
2022-03-17 13:18 ` [PATCH 1/3] nvmet: check for subsystem type in nvmet_find_get_subsys() Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405060742.GA24073@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox