From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 3/3] nvmet: include all configured ports in discovery log page for unique discover controller
Date: Tue, 5 Apr 2022 08:19:41 +0200 [thread overview]
Message-ID: <20220405061941.GA24290@lst.de> (raw)
In-Reply-To: <a129df40-6195-8b59-aa76-e3053e0960fd@suse.de>
On Tue, Apr 05, 2022 at 08:15:51AM +0200, Hannes Reinecke wrote:
> To make it configurable.
> Unique discovery controllers show up in configfs just like any other
> subsystems.
> And with that we need to clarify the relationship between the discovery
> subsystem and the other subsystems, ie which subsystems should be presented
> by this discovery subsystem.
>
> Linking the discovery subsystem into a given port makes it obvious that
> a) this port will be presenting a discovery subsystem
> and
> b) that the discovery subsystem will be presenting all subsystems
> configured on that port.
>
> The built-in mechanism for discovery subsystems was okay as long as the
> discovery subsystem was built-in, too.
> But with this patchset we're moving to an explicit configuration.
Shouldn't we just require anything to be manually listed for this
case similar to how we configure referrals for the well known
discovery controller?
next prev parent reply other threads:[~2022-04-05 6:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 14:26 [PATCHv2 0/3] nvmet: unique discovery subsystem Hannes Reinecke
2022-03-17 14:26 ` [PATCH 1/3] nvmet: check for subsystem type in nvmet_find_get_subsys() Hannes Reinecke
2022-04-05 5:45 ` Christoph Hellwig
2022-04-05 5:53 ` Hannes Reinecke
2022-04-05 6:07 ` Christoph Hellwig
2022-04-05 13:06 ` John Meneghini
2022-03-17 14:26 ` [PATCH 2/3] nvmet: make the subsystem type configurable Hannes Reinecke
2022-04-05 5:47 ` Christoph Hellwig
2022-04-05 6:00 ` Hannes Reinecke
2022-04-05 6:09 ` Christoph Hellwig
2022-04-05 6:29 ` Hannes Reinecke
2022-04-05 10:35 ` Sagi Grimberg
2022-04-05 11:12 ` Hannes Reinecke
2022-04-05 15:02 ` John Meneghini
2022-04-05 13:15 ` John Meneghini
2022-03-17 14:26 ` [PATCH 3/3] nvmet: include all configured ports in discovery log page for unique discover controller Hannes Reinecke
2022-04-05 5:46 ` Christoph Hellwig
2022-04-05 6:15 ` Hannes Reinecke
2022-04-05 6:19 ` Christoph Hellwig [this message]
2022-04-05 6:35 ` Hannes Reinecke
2022-04-05 7:31 ` Christoph Hellwig
2022-04-05 10:32 ` Sagi Grimberg
2022-04-05 15:09 ` John Meneghini
2022-04-06 11:39 ` Hannes Reinecke
2022-04-05 10:41 ` Sagi Grimberg
2022-04-05 11:01 ` Hannes Reinecke
2022-04-05 14:22 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2022-03-17 13:18 [PATCH 0/3] nvmet: unique discovery subsystem Hannes Reinecke
2022-03-17 13:18 ` [PATCH 3/3] nvmet: include all configured ports in discovery log page for unique discover controller Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405061941.GA24290@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox