From: Christoph Hellwig <hch@lst.de>
To: Tao Jin <me@kingtous.cn>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, axboe@fb.com, sagi@grimberg.me,
kingtous <kingtous@qq.com>
Subject: Re: [PATCH] fix: nvme_update_ns_info method should be called even if nvme_ms_ids_equal return false
Date: Sat, 9 Apr 2022 06:43:51 +0200 [thread overview]
Message-ID: <20220409044351.GA17212@lst.de> (raw)
In-Reply-To: <21ac620f-d234-13a1-0de7-e3ec1b3272db@kingtous.cn>
On Sat, Apr 09, 2022 at 08:58:27AM +0800, Tao Jin wrote:
> Note that I'm using the kernel which customed by myself, which comments out
> "goto out_free_id". It means "nvme_update_ns_info" will be called even if
> invalidate ids failed. Because I can't do suspend operation if using
> official kernel, which will cause my SSD directly invisible in Linux and
> trigger ext4 error, freezing the laptop.
Thanks for the update. This proves two things:
a) the device is completely broken in reporting IDs
b) the reason why the eui64 changes after each suspend is because the
kernel is inconsistent in how it queries for the eui64
I'll prepare patches to fix both issues over the weekend.
next prev parent reply other threads:[~2022-04-09 4:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 2:57 [PATCH] fix: nvme_update_ns_info method should be called even if nvme_ms_ids_equal return false me
2022-04-08 5:19 ` Christoph Hellwig
[not found] ` <ABwAxgCYBwe5Iq2fM1-8qqrc.3.1649398333597.Hmail.me@kingtous.cn>
2022-04-08 6:22 ` Christoph Hellwig
2022-04-08 7:56 ` 金韬
2022-04-08 8:07 ` Christoph Hellwig
2022-04-08 8:35 ` 金韬
2022-04-08 15:18 ` Keith Busch
2022-04-08 16:04 ` Christoph Hellwig
2022-04-09 0:58 ` Tao Jin
2022-04-09 4:43 ` Christoph Hellwig [this message]
2022-04-09 9:11 ` Tao Jin
2022-04-11 5:49 ` Christoph Hellwig
2022-04-11 5:56 ` 金韬
2022-04-11 6:07 ` Christoph Hellwig
2022-04-11 14:20 ` 金韬
2022-04-12 5:04 ` Christoph Hellwig
2022-04-12 6:34 ` 金韬
2022-05-23 18:18 ` Arman Hajishafieha
2022-05-24 13:50 ` hch
2022-05-24 16:51 ` Arman Hajishafieha
2022-05-24 20:54 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220409044351.GA17212@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=kingtous@qq.com \
--cc=linux-nvme@lists.infradead.org \
--cc=me@kingtous.cn \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox