Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

David Sterba
2022-04-11T17:31:48Z

On Sat, Apr 09, 2022 at 06:50:40AM +0200, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
>
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> [btrfs]
> Acked-by: Coly Li <colyli@suse.de> [bcache]
> ---
> arch/um/drivers/ubd_kern.c | 2 --
> block/blk-core.c | 2 +-
> block/blk-lib.c | 2 +-
> block/blk-mq-debugfs.c | 1 -
> block/ioctl.c | 3 +--
> drivers/block/drbd/drbd_main.c | 2 +-
> drivers/block/drbd/drbd_nl.c | 19 ++-----------------
> drivers/block/drbd/drbd_receiver.c | 3 +--
> drivers/block/loop.c | 11 +++--------
> drivers/block/nbd.c | 5 +----
> drivers/block/null_blk/main.c | 1 -
> drivers/block/rbd.c | 1 -
> drivers/block/rnbd/rnbd-clt.c | 2 --
> drivers/block/rnbd/rnbd-srv-dev.h | 3 ---
> drivers/block/virtio_blk.c | 2 --
> drivers/block/xen-blkback/xenbus.c | 2 +-
> drivers/block/xen-blkfront.c | 2 --
> drivers/block/zram/zram_drv.c | 1 -
> drivers/md/bcache/request.c | 4 ++--
> drivers/md/bcache/super.c | 3 +--
> drivers/md/bcache/sysfs.c | 2 +-
> drivers/md/dm-cache-target.c | 9 +--------
> drivers/md/dm-clone-target.c | 9 +--------
> drivers/md/dm-log-writes.c | 3 +--
> drivers/md/dm-raid.c | 9 ++-------
> drivers/md/dm-table.c | 9 ++-------
> drivers/md/dm-thin.c | 11 +----------
> drivers/md/dm.c | 3 +--
> drivers/md/md-linear.c | 11 +----------
> drivers/md/raid0.c | 7 -------
> drivers/md/raid1.c | 16 +---------------
> drivers/md/raid10.c | 18 ++----------------
> drivers/md/raid5-cache.c | 2 +-
> drivers/md/raid5.c | 12 ++++--------
> drivers/mmc/core/queue.c | 1 -
> drivers/mtd/mtd_blkdevs.c | 1 -
> drivers/nvme/host/core.c | 6 ++----
> drivers/s390/block/dasd_fba.c | 1 -
> drivers/scsi/sd.c | 2 --
> drivers/target/target_core_device.c | 2 +-

For

> fs/btrfs/extent-tree.c | 4 ++--
> fs/btrfs/ioctl.c | 2 +-

Acked-by: David Sterba <dsterba@suse.com>