From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51C6EC433EF for ; Sun, 10 Apr 2022 06:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ReTqbfPvYOL5e7OV60JqE24oNyN9q4uiegyy86KDY98=; b=39uDNFTji50w4Ss5tRtV5dHtH+ vH+rX+au4mO/4A8OwcxVZ+TViYEWOnpgEdPPxUHDXt4rbeDciJKW3XrEusclO2OCItYxI+vW6SMjE yB+9WiEbYcekYHwCbFGHNDuREScFe4A9Gz0t2AicI/RCCdamPRpxqb0Bg+QFLuZS39ktW0I1TzB3J y0DLo8/zNQ3+nl/5ATsx33YrLjzjHJoSZMcT6JjsDwFbOX2sFbKLsWOrbYqO3Iz+diVUV1MOUXNDZ +sTk2MFvGecTXOl/8i18C6XHyioNNLYmIsgWPfhUMRp0m/x9qrX/OgEKqSRXDK0I+14MSFTcOgruy 6Xnw1Emw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndR3E-004J0u-Ub; Sun, 10 Apr 2022 06:27:56 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndR1q-004IUM-Pj; Sun, 10 Apr 2022 06:26:32 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E057168AFE; Sun, 10 Apr 2022 08:26:20 +0200 (CEST) Date: Sun, 10 Apr 2022 08:26:20 +0200 From: Christoph Hellwig To: Christoph =?iso-8859-1?Q?B=F6hmwalder?= Cc: Christoph Hellwig , dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Jens Axboe , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, "Martin K . Petersen" , Coly Li Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD Message-ID: <20220410062620.GA16234@lst.de> References: <20220409045043.23593-1-hch@lst.de> <20220409045043.23593-25-hch@lst.de> <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220409_232631_021111_4D311942 X-CRM114-Status: GOOD ( 12.10 ) X-Mailman-Approved-At: Sat, 09 Apr 2022 23:27:52 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sat, Apr 09, 2022 at 10:15:33AM +0200, Christoph Böhmwalder wrote: > On 09.04.22 06:50, Christoph Hellwig wrote: >> Just use a non-zero max_discard_sectors as an indicator for discard >> support, similar to what is done for write zeroes. >> >> The only places where needs special attention is the RAID5 driver, >> which must clear discard support for security reasons by default, >> even if the default stacking rules would allow for it. >> >> Signed-off-by: Christoph Hellwig >> Reviewed-by: Martin K. Petersen >> Acked-by: Christoph Böhmwalder [btrfs] > > I think you may have a typo there: my ACK was for drbd, not btrfs. Indeed, sorry.