Re: [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique

Christoph Hellwig
2022-06-06T15:03:50Z

On Mon, Jun 06, 2022 at 12:42:41PM +0000, Stefan wrote:
> Will do, but just to clarify: Is this a problem with my specific drive or
> with the controller? FWICT my drives use a Phison PS5016-E16, which seems
> quite common in consumer PCIe 4.0 SSDs.

In general ID reporting like this is a firmware issue, so it is not
directly related to the controller hardware. However for cheap
consumer drives most vendors simply take the default reference firmware
and ship it with the minimum required changes. So if Phison fucked this
up, chances are it will be in most of these controllers.

> If I add the quirk for 1cc1:5350 it would only override it for this
> specific ADATA/XPG model, correct?

Yes. We have to way to find out what actual controller hardware or
reference firmware a given device is based off.