Re: [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique

Keith Busch
2022-06-06T14:51:55Z

On Mon, Jun 06, 2022 at 08:40:55AM +0200, Christoph Hellwig wrote:
> On Sun, Jun 05, 2022 at 01:58:07AM +0000, Stefan wrote:
> > Ran into a boot failure on my workstation today and I traced it to this
> > commit, reverting it on v5.18.1 makes it work. Quad-nvme boot raid.
> >
> > I saw some follow-ups adding quirks, so I added NVME_QUIRK_BOGUS_NID to my
> > drives (1cc1:5350 for reference) and that worked too - if this is ok for an
> > actual patch let me know.
>
> Yes, please send the patch, the controller reports a non-uniqueue EUI64,
> the rest seems to be not reported at all and thus actually ok.

I am unable to reply to Stefan for some bizarre gpg issues...

But just fyi, this sounds like the same issue as the phison controller from a
different brand reported below, so it sounds more widespread than just this
particular adata model.

https://bugzilla.kernel.org/show_bug.cgi?id=216049

The reported didn't provide the device id, though, so we don't have a viable
patch for that product just yet. Perhaps we could add the vid:did to some of
the messages to help shorten the report-quirk cycle.