Re: [PATCH 2/4] nvme: fix the check for duplicate unique identifiers

Chaitanya Kulkarni
2022-02-24T22:52:07Z

On 2/24/22 11:28, Christoph Hellwig wrote:
> nvme_subsys_check_duplicate_ids should needs to return an error if any of
> the identifiers matches, not just if all of them match. But it does not
> need to and should not look at the CSI value for this sanity check.
>
> Rewrite the logic to be separate from nvme_ns_ids_equal and optimize it
> by reducing duplicate checks for non-present identifiers.
>
> Fixes: ed754e5deeb1 ("nvme: track shared namespaces")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>