Re: [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique

Christoph Hellwig
2022-06-17T09:01:19Z

On Wed, Jun 15, 2022 at 08:15:18PM +0000, Alan Adamson wrote:
> Here are my latest changes. It includes an interface from nvme-cli to specify
> to clear the IDs upon connect.
>
> Wasn’t sure the proper way to send a clear_ids argument to the target so I followed
> what kato did. Not sure if that is appropriate for this case.
>
> This will require a nvme-cli change and blktests changes. I tested with both loop and tcp.

Well, it changes the nvme over the wire protocol, we can't just do
that.

And the option really is a target side one, that is we want to configure
it using configfs on the target, not the fabrics command line options.

That is, add a new clear_ids attribute to nvmet_passthru_attrs, save
the flag in struct nvmet_subsys, and default to true for loop controllers.