Re: [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique

Christoph Hellwig
2022-06-06T15:06:50Z

On Mon, Jun 06, 2022 at 08:51:34AM -0600, Keith Busch wrote:
> But just fyi, this sounds like the same issue as the phison controller from a
> different brand reported below, so it sounds more widespread than just this
> particular adata model.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=216049
>
> The reported didn't provide the device id, though, so we don't have a viable
> patch for that product just yet. Perhaps we could add the vid:did to some of
> the messages to help shorten the report-quirk cycle.

Yes, that's probably useful. I've also been wondering if we need a
kernel command line interface to enable quirks for given IDs, similar
to what SCSI has. With the amount of amazingly crappy consumer devices
our number of quirks will keep growing exponentially unless we can finally
get the NVMe interop group to actually test for these kinds of real life
bug instead of silly crap like status code precedence.