Re: [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique

Klaus Jensen
2022-04-11T06:11:29Z

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

On Apr 11 08:09, Christoph Hellwig wrote:
> On Mon, Apr 11, 2022 at 08:01:51AM +0200, Klaus Jensen wrote:
> >
> > > I can also not find any code that would assign a different uuid
> > > when using a different command line syntax, but given how unusable
> > > the new syntax is I've not actually been able to try it.
> > >
> >
> > Are you referring to -device nvme-ns "syntax"?
>
> Yes.
>

Point taken.

> > Luckily we can do that easier now since we moved away from the Intel id
> > (which got rid of a bunch of quirks at that time).
> >
> > I'll see what we can come up with to fix this properly in QEMU.
>
> Thanks. Please Cc me on the patches. My qemu-foo is getting a little
> rusty, but I should still be able to help with the spec side.

Will do. Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]