From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH 2/3] nvme-core: don't check non-mdts for disc ctrl
Date: Mon, 11 Apr 2022 14:12:09 +0200 [thread overview]
Message-ID: <20220411121209.GA21711@lst.de> (raw)
In-Reply-To: <d86c4a83-ac9d-f0b1-de41-5d411f5444f3@nvidia.com>
On Mon, Apr 11, 2022 at 12:09:31PM +0000, Chaitanya Kulkarni wrote:
> - ret = nvme_init_non_mdts_limits(ctrl);
> - if (ret < 0)
> - return ret;
> + if (ctrl->cntrltype == NVME_CTRL_IO) {
> + ret = nvme_init_non_mdts_limits(ctrl);
> + if (ret < 0)
> + return ret;
> + }
This looks better, but I don't think it will actually work as-is.
The CNTRLTYPE field is never than discovry controllers. We
special case them in nvme_init_subsystem, which should move to
nvme_init_identify instead so that ctrl->cntrltype is always valid
after that.
next prev parent reply other threads:[~2022-04-11 12:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 3:12 [PATCH 0/3] nvme: fix internal passthru error messages Chaitanya Kulkarni
2022-04-11 3:12 ` [PATCH 1/3] nvmet: handle admin default command set identifier Chaitanya Kulkarni
2022-04-11 6:18 ` Christoph Hellwig
2022-05-10 6:33 ` Christoph Hellwig
2022-04-11 3:12 ` [PATCH 2/3] nvme-core: don't check non-mdts for disc ctrl Chaitanya Kulkarni
2022-04-11 6:13 ` Christoph Hellwig
2022-04-11 10:27 ` Sagi Grimberg
2022-04-11 10:49 ` Chaitanya Kulkarni
2022-04-11 12:09 ` Chaitanya Kulkarni
2022-04-11 12:12 ` Christoph Hellwig [this message]
2022-04-11 12:40 ` Chaitanya Kulkarni
2022-04-11 14:14 ` Keith Busch
2022-04-11 20:44 ` Chaitanya Kulkarni
2022-04-11 23:51 ` Keith Busch
2022-05-10 6:21 ` Christoph Hellwig
2022-05-11 7:19 ` Chaitanya Kulkarni
2022-04-11 3:12 ` [PATCH 3/3] nvme-core: mark internal passthru req REQ_QUIET Chaitanya Kulkarni
2022-04-11 6:12 ` Christoph Hellwig
2022-04-11 10:48 ` Chaitanya Kulkarni
2022-04-11 10:28 ` Sagi Grimberg
2022-04-11 10:49 ` Chaitanya Kulkarni
2022-04-13 12:07 ` Yi Zhang
2022-04-15 5:59 ` Chaitanya Kulkarni
2022-04-13 16:48 ` Jonathan Derrick
2022-04-13 16:49 ` Jonathan Derrick
2022-04-13 16:52 ` Christoph Hellwig
2022-04-13 16:57 ` Jonathan Derrick
2022-04-13 17:09 ` Keith Busch
2022-04-13 17:11 ` Jonathan Derrick
2022-04-15 6:01 ` Chaitanya Kulkarni
2022-04-13 16:58 ` Keith Busch
2022-04-13 18:42 ` Alan Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411121209.GA21711@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox