Re: [PATCH 3/3] nvme-core: mark internal passthru req REQ_QUIET

Christoph Hellwig
2022-04-13T16:52:51Z

On Wed, Apr 13, 2022 at 10:49:33AM -0600, Jonathan Derrick wrote:
>> + req->rq_flags |= RQF_QUIET;
> Any reason to not make it a part of flags in the argument list and let the
> block layer build the req with it?
>
> eg:
> flags |= REQ_QUIET;

Because there is not REQ_QUIET, just RQF_QUIET and BIO_QUIET, and their
relation isn't quite as straightforward as it seems.