Re: [PATCH 3/3] nvme-core: mark internal passthru req REQ_QUIET

Chaitanya Kulkarni
2022-04-15T06:04:57Z

>> Well let's suppose I had written RQF_QUIET instead of the non-existent
>> REQ_QUIET
>
> The "flags" value passed to blk_mq_alloc_request() is not the same as the
> values for rq_flags, though.
>
> I guess you could add a new allocation flag, maybe called something like
> BLK_MQ_REQ_QUIET to tell the block layer to set RQF_QUIET. That is similiar to
> how BLK_MQ_REQ_PM is used for RQF_PM, but I'm not sure we want to add another
> 'if' check in the fast path.

unless it is absolutely necessary we should avoid that.

-ck