Re: [PATCH] fix: nvme_update_ns_info method should be called even if nvme_ms_ids_equal return false

Christoph Hellwig
2022-04-09T04:44:04Z

On Sat, Apr 09, 2022 at 08:58:27AM +0800, Tao Jin wrote:
> Note that I'm using the kernel which customed by myself, which comments out
> "goto out_free_id". It means "nvme_update_ns_info" will be called even if
> invalidate ids failed. Because I can't do suspend operation if using
> official kernel, which will cause my SSD directly invisible in Linux and
> trigger ext4 error, freezing the laptop.

Thanks for the update. This proves two things:

a) the device is completely broken in reporting IDs
b) the reason why the eui64 changes after each suspend is because the
kernel is inconsistent in how it queries for the eui64

I'll prepare patches to fix both issues over the weekend.